search

safe-global / safe-transaction-service

Keeps track of transactions sent via Safe contacts and confirmed transactions. It also keeps track of Ether and ERC20 token transfers to Safe contracts.
MIT License
182 stars 246 forks source link

Incorrect type for /v2/delegate endpoint delegateAddress #2084

Closed njelich closed 2 weeks ago

njelich commented 3 weeks ago

Describe the bug In the signTypedData form for the Safe Transaction Service, the following type is used as AddDelegate:

        "AddDelegate": [
            {"name": "delegateAddress", "type": "bytes32"},
            {"name": "totp", "type": "uint256"},
        ],

However, the correct type for delegateAddress would be address. This way a normal provided address needs to be left padded.

njelich commented 2 weeks ago

Tagging @Uxio0 and @moisses89 since the code will be touched as part of the all chain signing.