search

safe-global / safe-transaction-service

Keeps track of transactions sent via Safe contacts and confirmed transactions. It also keeps track of Ether and ERC20 token transfers to Safe contracts.
MIT License
182 stars 246 forks source link

[ API ] Get token logos from trusted lists #2103

Open moisses89 opened 1 week ago

moisses89 commented 1 week ago

What is needed?

Currently the logos need to be uploaded manually in the transaction service by the admin page. This is hard to manage when we need to update large quantity of tokens. My suggestion is take advantage of trusted lists that are configured in the service and get the logos from there when there is not any logo upload for the token. At this way the service would need less maintenance updating tokens logos.

Example of list: https://tokens.coingecko.com/uniswap/all.json.

Uxio0 commented 4 days ago

FYI @hectorgomezv we will implement this but images logic should be moved to wallet side

hectorgomezv commented 4 days ago

FYI @hectorgomezv we will implement this but images logic should be moved to wallet side

It makes total sense to me 👍🏻