Optimize Module Transaction fetching

safe-global / safe-transaction-service

Keeps track of transactions sent via Safe contacts and confirmed transactions. It also keeps track of Ether and ERC20 token transfers to Safe contracts.

MIT License

182 stars 246 forks source link

Optimize Module Transaction fetching #2112

Closed Uxio0 closed 6 days ago

Uxio0 commented 1 week ago

Modify ModuleTransaction model:
- Create an index for safe and created, including internal_tx_id for JOIN
- Remove safe index, as the previous index will be used
- Refactor unique id calculation inside of model
Update ModuleTransaction query for all-transactions to use created instead of internal_tx__created field. It has the same value and can use indexes
Rename ModuleTransaction view to follow the same convention

Uxio0 commented 6 days ago

@JagoFigueroa for QA some endpoints need to be checked, all with ModuleTransactions:

All-transactions
List of module transactions for a Safe
Getting a module transaction by unique id

JagoFigueroa commented 5 days ago

Looking good to me! 😄

Uxio0 commented 4 days ago

Thanks!