search

safe-global / safe-user-allocation-reports

The proposed list of SAFE user allocations has been published on the Safe forum.
Creative Commons Zero v1.0 Universal
34 stars 10 forks source link

Reward safe address mistakes in issue 204 and 220 #526

Closed Neverlander0 closed 2 years ago

Neverlander0 commented 2 years ago

https://github.com/safe-global/safe-user-allocation-reports/blob/42697e4438244c992ec993c417ea885b06a3d8af/review/valid_reports.csv

Although these mistakes have nothing to do with me , i should point it out.

Thanks for the Safe team and all witch hunters.

tschubotz commented 2 years ago

For #220, 0x984129b1c8d6048df516d81f730475af7d0e4232 is used as specified in the issue: https://github.com/safe-global/safe-user-allocation-reports/issues/220#issue-1367323364

Fpr #204, 0xcee6063D59e3fF951677AD1E1B2b58C686efFA50 is used as specified in the issue: https://github.com/safe-global/safe-user-allocation-reports/issues/204#issue-1367189619

Where exactly do you see a mistake?

tschubotz commented 2 years ago

Found the mistake, thanks a lot.

CaptainTee commented 2 years ago

Yes! I found the error now.

The error is still not fixed, please @tschubotz It was only fix for the first address on the list while the last digit for addresses has changed. This usually happen when one highlights number on drag is down on Excel

0xcee6063D59e3fF951677AD1E1B2b58C686efFA50 ✅ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA51 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA52 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA53 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA54 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA55 ❌

Please fix it @tschubotz Cc: @lukasschor

Neverlander0 commented 2 years ago

Yes! I found the error now.

The error is still not fixed, please @tschubotz It was only fix for the first address on the list while the last digit for addresses has changed. This usually happen when one highlights number on drag is down on Excel

0xcee6063D59e3fF951677AD1E1B2b58C686efFA50 ✅ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA51 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA52 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA53 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA54 ❌ 0xcee6063D59e3fF951677AD1E1B2b58C686efFA55 ❌

Please fix it @tschubotz Cc: @lukasschor

https://raw.githubusercontent.com/safe-global/safe-user-allocation-reports/main/review/valid_reports.csv Now it was fixed, no need to worry.

CaptainTee commented 2 years ago

Alright, Thank you, friend