safe-global / safe-wallet-web

Safe{Wallet} – multisig EVM wallet
https://app.safe.global
GNU General Public License v3.0
352 stars 416 forks source link

Sepolia support #1550

Closed ligi closed 1 year ago

ligi commented 1 year ago

Jamie originally opened this issue here: https://github.com/safe-global/safe-react/issues/4139 but it is now gone - so opening it again. Sepolia is the new testnet for apps - - see e.g. @q9f 's talk from https://github.com/efdevcon here: https://archive.devcon.org/archive/watch/6/post-merge-testnets

image

see also : https://blog.ethereum.org/2022/06/21/testnet-deprecation

katspaugh commented 1 year ago

This is the repo for the web front end, so I'll mark it as blocked and share it with the infra team. The entire stack for Sepolia would have to be created, not just the UI.

katspaugh commented 1 year ago

cc @FahdSaif – please feel free to move this issue and track it on the infra side.

katspaugh commented 1 year ago

I'm copying @jpitt's original issue here because issues are disabled in the legacy safe-react repo:

Overview

Requesting the addition of Sepolia testnet to the Safe user interface.

Goerli is the only testnet appearing in the user interface, yet Sepolia is also a recommended testnet. Currently, Sepolia is recommended for application developers, whereas Goerli is recommended for testing validation and staking. Also, the v1.3.0 Safe contracts have already been deployed to Sepolia (see: Sepolia Etherscan and Safe deployment config file w/ Sepolia network ID 11155111).

EF Devops would specifically like to have this added so that the tokens for permissioned sepolia validators can be conveniently managed by the team members using the Safe dapp. It is also critical for application developers in the community to have Sepolia added in order to test with Safe.

Requirements

Please let me know if there is a need to have the transaction service supported or run, or if deploying the service is not feasible for some reason.

Designs

In the drop-down, perhaps use the dayglo green lettering on dark grey background (as used on the Sepolia info website). It should go above or below Goerli.

image image

Links

Feb 2020 request for Goerli Testnet Version Issue https://github.com/safe-global/safe-react/issues/600

General info about Sepolia testnet

liliya-soroka commented 1 year ago

Most likely we will go with support Holesovice by the end of 2023 instead of Goerli https://ethereum-magicians.org/t/proposal-predictable-ethereum-testnet-lifecycle/11575 There is no plan to add Sepolia as a test network

katspaugh commented 1 year ago

Closing this, since chain support is added on the backend, not frontend, and we don't need to track it here.