Open jsvisa opened 3 months ago
Seems it's something like this one https://github.com/safe-global/safe-wallet-web/issues/1886#issuecomment-1537075441
The EIP1271 integration is merged in https://github.com/safe-global/safe-core-sdk/pull/556
But curious, on web's side, it did encode the signatures before execute the tx
After investigating this a bit with @schmanu, the bug is likely here: https://github.com/safe-global/safe-wallet-web/blob/dev/src/services/tx/tx-sender/create.ts#L122-L130
The dynamic part is always set to ''
which is wrong for nested Safe signatures.
@katspaugh thanks for the debugging, looking forward to the bugfix.
Bug description
Environment
Steps to reproduce
Now it has 3 approves
Now I click the simulate button, but it failed:
Tenderly's link https://dashboard.tenderly.co/public/safe/safe-apps/simulator/ff6bbdae-1431-4a70-8a99-553ba01cd5cb
Seems the input is incorrect
We should put the contract's dynamic signature in the ending, but it is simple concated in the input
Expected result
Merge the signature before simulate or execute the transaction.
So I execute the transaction with the merged signature in python, it succeed: