Closed compojoom closed 1 month ago
β Deploy successful!
Storybook: https://fix_enable_for_counterfactual_safes--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
1000.79Β KB (π‘ +19Β B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/balances |
29.47Β KB (π’ -17Β B) |
1.01Β MB |
/home |
58.7Β KB (π’ -7Β B) |
1.03Β MB |
/settings/cookies |
7.64Β KB (π’ -2Β B) |
1008.43Β KB |
/terms |
11.58Β KB (π‘ +1.56Β KB) |
1012.38Β KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.01% (-0.05% π») |
11613/14698 |
π΄ | Branches | 58.6% (-0.02% π») |
2847/4858 |
π‘ | Functions | 65.97% (-0.1% π») |
1855/2812 |
π’ | Lines | 80.4% (-0.04% π») |
10471/13024 |
1433 tests passing in 198 suites.
Report generated by π§ͺjest coverage report action from 53a7b34b7622a1afa6e99bd594be91a87f41ba13
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
What it solves
Cow was not being able to work with counterfactual safes - it was showing the widget as not connected.
Resolves # Now the widget is connected to the safe and one can submit an order.
How this PR fixes it
How to test it
Create counterfactual safe
Fund it with money
Try to make a swap
Create a safe and deploy it right away
Create counterfactual safe and activate it without a transaction
Screenshots
Checklist