fix: re-enable swaps for counterfactual safes [SW-23]

compojoom commented 2 months ago

What it solves

Cow was not being able to work with counterfactual safes - it was showing the widget as not connected.

Resolves # Now the widget is connected to the safe and one can submit an order.

How this PR fixes it

How to test it

Create counterfactual safe
Fund it with money
Try to make a swap
Create a safe and deploy it right away
Create counterfactual safe and activate it without a transaction

Screenshots

Checklist

[ ] I've tested the branch on mobile 📱
[ ] I've documented how it affects the analytics (if at all) 📊
[ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

notion-workspace[bot] commented 2 months ago

Re-enable for counterfactual safe

github-actions[bot] commented 2 months ago

Branch preview

✅ Deploy successful!

Website: https://fix_enable_for_counterfactual_safes--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_enable_for_counterfactual_safes--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 2 months ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1000.79 KB` (🟡 +19 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/balances`	`29.47 KB` (🟢 -17 B)	1.01 MB
`/home`	`58.7 KB` (🟢 -7 B)	1.03 MB
`/settings/cookies`	`7.64 KB` (🟢 -2 B)	1008.43 KB
`/terms`	`11.58 KB` (🟡 +1.56 KB)	1012.38 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 2 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79.01% (-0.05% 🔻)	11613/14698
🔴	Branches	58.6% (-0.02% 🔻)	2847/4858
🟡	Functions	65.97% (-0.1% 🔻)	1855/2812
🟢	Lines	80.4% (-0.04% 🔻)	10471/13024

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🔴 |

`...` / undeployedSafesSlice.ts

|

41.18% (-5.88% 🔻)

| 33.33% |

50% (-12.5% 🔻)

|

45.83% (-4.17% 🔻)

| | 🟢 |

`...` / index.tsx

|

82.35% (-8.82% 🔻)

|

66.67% (-16.67% 🔻)

|

50% (-12.5% 🔻)

|

83.87% (-9.68% 🔻)

|

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 53a7b34b7622a1afa6e99bd594be91a87f41ba13

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

notion-workspace[bot] commented 2 months ago

Re-enable for counterfactual safe

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

safe-global / safe-wallet-web