safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
327 stars 392 forks source link

feat: decode txs in swap modal [SWAP-81] #3764

Closed schmanu closed 2 months ago

schmanu commented 2 months ago

What it solves

Resolves SWAP-81

How this PR fixes it

How to test it

Screenshots

Checklist

notion-workspace[bot] commented 2 months ago

Better decoding - designs

github-actions[bot] commented 2 months ago

Branch preview

βœ… Deploy successful!

Website: https://feat_swap_titles--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://feat_swap_titles--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 2 months ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.6 KB (🟑 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/swap 29.67 KB (🟑 +523 B) 980.28 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 2 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.49% (-0.02% πŸ”»)
11533/14509
πŸ”΄ Branches
58.55% (-0.02% πŸ”»)
2776/4741
🟑 Functions
66.76% (-0.04% πŸ”»)
1854/2777
🟒 Lines
80.84% (-0.02% πŸ”»)
10404/12870
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟒 |
`...` / index.tsx
|
82.35% (-8.82% πŸ”»)
|
66.67% (-16.67% πŸ”»)
|
50% (-12.5% πŸ”»)
|
83.87% (-9.68% πŸ”»)
|

Test suite run success

1449 tests passing in 199 suites.

Report generated by πŸ§ͺjest coverage report action from b6d97675f1cbfa64161df57e0a460690c6537cdc

francovenica commented 2 months ago

"Unwrap" is missing. This is when you swap WETH for ETH. image

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

francovenica commented 2 months ago

LGTM: image