search

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
327 stars 392 forks source link

Release 1.37.1 #3766

Closed katspaugh closed 2 months ago

katspaugh commented 2 months ago

Features

Analytics

Bug fixes

Chores & tests

github-actions[bot] commented 2 months ago

Branch preview

⏳ Deploying a preview site...

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 2 months ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] commented 2 months ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements
79.47% (+0.21% 🔼)
 11295/14213
🔴 Branches
58.46% (+0.3% 🔼)
 2699/4617
🟡 Functions
66.67% (+0.36% 🔼)
 1822/2733
🟢 Lines
80.85% (+0.24% 🔼)
 10185/12597
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |
`...` / index.tsx
| 100% | 93.1% | 100% | 100% | | 🟢 |
`...` / index.tsx
| 94.44% | 87.5% | 100% | 94.12% |
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🔴 |
`...` / web3.ts
|
63.27% (-8.16% 🔻)
|
8.33% (-16.67% 🔻)
|
28.57% (-28.57% 🔻)
|
57.89% (-10.53% 🔻)
| | 🟢 | src/utils/chains.ts |
88.89% (-2.78% 🔻)
|
83.33% (-16.67% 🔻)
| 100% | 100% | | 🟡 |
`...` / sdk.ts
|
69.79% (-1.18% 🔻)
|
38.1% (-4.01% 🔻)
| 69.23% |
68.6% (-1.27% 🔻)
| | 🟢 |
`...` / consts.ts
|
66.67% (-33.33% 🔻)
| 100% | 100% | 100% | | 🔴 |
`...` / useOnboard.ts
|
44.63% (-6.15% 🔻)
|
11.11% (-12.7% 🔻)
| 15% |
47.66% (-5.85% 🔻)
| | 🟢 |
`...` / useSafeCreation.ts
|
90% (-0.12% 🔻)
| 84.38% | 55.56% |
90.67% (-0.12% 🔻)
| | 🟢 |
`...` / safeTheme.ts
|
90.7% (-2.16% 🔻)
| 50% |
90% (-3.1% 🔻)
|
92.68% (-2.32% 🔻)
| | 🟢 |
`...` / usePendingTxs.ts
| 89.58% |
82.35% (-0.98% 🔻)
|
92.31% (+1.4% 🔼)
| 92.5% | | 🟢 |
`...` / WalletConnectWallet.ts
|
90.36% (-0.11% 🔻)
|
89.47% (-1% 🔻)
| 84% |
92.41% (-0.09% 🔻)
| | 🔴 |
`...` / index.tsx
|
24.44% (-31.11% 🔻)
|
0% (-19.05% 🔻)
|
14.29% (-28.57% 🔻)
|
24.39% (-29.27% 🔻)
| | 🟡 |
`...` / index.tsx
|
66.67% (-22.22% 🔻)
|
0% (-50% 🔻)
|
0% (-66.67% 🔻)
|
75% (-12.5% 🔻)
| | 🔴 |
`...` / useAllOwnedSafes.ts
|
38.89% (-2.29% 🔻)
| 0% | 0% |
41.18% (-8.82% 🔻)
| | 🟢 |
`...` / index.tsx
|
87.5% (-12.5% 🔻)
| 100% | 100% | 100% | | 🟡 |
`...` / index.tsx
|
76.53% (-1.77% 🔻)
|
53.13% (+1.96% 🔼)
| 72.73% |
77.17% (-1.83% 🔻)
| | 🟢 |
`...` / index.tsx
|
92.86% (-7.14% 🔻)
| 100% | 100% | 100% | | 🟢 |
`...` / index.tsx
|
88.89% (-0.58% 🔻)
|
85.71% (-5.95% 🔻)
|
75% (+15% 🔼)
|
87.5% (-3.68% 🔻)
|

Test suite run success

1436 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 7537a6268ed24e9a8e3205600d2779382010c0ed

francovenica commented 2 months ago

Board for feedback: https://www.notion.so/safe-global/1f1df3f06ead4378ab1c9c3de24951b1?v=6ad2667b868d4c0f8cf18e129f762583&p=fe77f270babe4b2084ab70f07b7cc5a3&pm=s

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

francovenica commented 2 months ago

Question regarding the infura token for dev. Currently in the PR where this was developed initially, the infura URL you can see in the settings is, as expected, different than the one in current prod The thing is that after merging that to the release, the infura URL in the settings is the same as the one in current prod. Could this be because the release branch is tagged as prod? or should this release also have the same infura URL in the settings as the original PR and we have an issue?

francovenica commented 2 months ago

I tried to check that las commit regarding the change in how tx in bulk is tracked in analytics, but I don't see any GTM calls all of the sudden. Those were there before since I even reported an issue about them in the board. Any recent changes that might have disable/hide them from showing up in the dev console?

katspaugh commented 2 months ago

@francovenica yes, exactly, the RC branches will use all the production settings. CGW will also be the prod version.

francovenica commented 2 months ago

It seems that the GTM calls are not being shown anymore because now the release branch is "like prod".

I went back to the PR's that did the changes in the GTM tracks 3779 and 3783 and test those fixed there and they work fine.

francovenica commented 2 months ago

The rest of the regression went fine, and the last commits were checked and they worked fine.

There is an ongoing discussion if we should keep the "use different infura for dev" change, so if it is decied to roll back that change let me know

If not, then the RC looks good for release

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action