Closed katspaugh closed 2 months ago
β³ Deploying a preview site...
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
This PR introduced no changes to the JavaScript bundle! π
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.47% (+0.21% πΌ) |
11295/14213 |
π΄ | Branches | 58.46% (+0.3% πΌ) |
2699/4617 |
π‘ | Functions | 66.67% (+0.36% πΌ) |
1822/2733 |
π’ | Lines | 80.85% (+0.24% πΌ) |
10185/12597 |
1436 tests passing in 197 suites.
Report generated by π§ͺjest coverage report action from 7537a6268ed24e9a8e3205600d2779382010c0ed
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
Question regarding the infura token for dev. Currently in the PR where this was developed initially, the infura URL you can see in the settings is, as expected, different than the one in current prod The thing is that after merging that to the release, the infura URL in the settings is the same as the one in current prod. Could this be because the release branch is tagged as prod? or should this release also have the same infura URL in the settings as the original PR and we have an issue?
I tried to check that las commit regarding the change in how tx in bulk is tracked in analytics, but I don't see any GTM calls all of the sudden. Those were there before since I even reported an issue about them in the board. Any recent changes that might have disable/hide them from showing up in the dev console?
@francovenica yes, exactly, the RC branches will use all the production settings. CGW will also be the prod version.
It seems that the GTM calls are not being shown anymore because now the release branch is "like prod".
I went back to the PR's that did the changes in the GTM tracks 3779 and 3783 and test those fixed there and they work fine.
The rest of the regression went fine, and the last commits were checked and they worked fine.
There is an ongoing discussion if we should keep the "use different infura for dev" change, so if it is decied to roll back that change let me know
If not, then the RC looks good for release
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
Features
Analytics
Bug fixes
WalletConnect
Fix: back button style (#3742)
Fix: missing feature toggles (#3748)
fix: do not show nonce conflict warning for batch transactions. (#3608)
Fix: rearrange Settings tabs (#3751)
Fix: memoize Safe List data (#3729)
Fix: move rhino.fi to warned bridges (#3740)
fix: Hide signed transaction from untrusted pending queue (#3710)
fix: Add network to Rabby if unknown (#3776)
Chores & tests