feat: slight UI improvements to the new tx flow [SWAP-89]

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)

https://app.safe.global

GNU General Public License v3.0

327 stars 392 forks source link

feat: slight UI improvements to the new tx flow [SWAP-89] #3767

Closed compojoom closed 2 months ago

compojoom commented 2 months ago

What it solves

Added a swap tokens there and slightly updated the visual presentation according to the figma: https://www.figma.com/design/VyA38zUPbJ2zflzCIYR6Nu/Swap?node-id=6588-48609&t=LhvUJl76y7PuTnIS-4

How to test it

Hit the "New Transaction" button and enjoy!

Screenshots

Checklist

[ ] I've tested the branch on mobile 📱
[ ] I've documented how it affects the analytics (if at all) 📊
[ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

notion-workspace[bot] commented 2 months ago

Add swaps to new tx page

github-actions[bot] commented 2 months ago

Branch preview

✅ Deploy successful!

Website: https://feat_swaps_new_tx--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://feat_swaps_new_tx--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 2 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 2 months ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`949.93 KB` (🟡 +7 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 2 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79.48%	11292/14208
🔴	Branches	58.5%	2699/4614
🟡	Functions	66.65%	1821/2732
🟢	Lines	80.86%	10182/12592

Test suite run success

1436 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 224ecbcc6fcb3d3a849adeb707ae6366a0fc45b6

francovenica commented 2 months ago

LGTM Checked in dark mode and mobile viewport The buttons work fine, they take where they should