Closed katspaugh closed 1 month ago
β Deploy successful!
Storybook: https://chain_redirect--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
950.05Β KB (π‘ +35Β B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Had to read the conversation in the review to understand what it was the purpose of the ticket.
LGTM Being in a safe of NetworkA and switching to networkB in the top right corner takes the user to the safe selection (/welcome/accounts) instead of the welcome page (/welcome).
It seems this only happens if the user is connected. I think diconnected users also can be taken to the /welcome/accounts page since the user might have safes in his watchlist, but is not a blocker
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.47% (-0.02% π») |
11307/14228 |
π΄ | Branches | 58.44% (-0.02% π») |
2704/4627 |
π‘ | Functions | 66.57% (-0.04% π») |
1820/2734 |
π’ | Lines | 80.85% (-0.02% π») |
10197/12612 |
1437 tests passing in 197 suites.
Report generated by π§ͺjest coverage report action from 645eec6b1bebce047c54f2594e574fe75b1fbdb4
What it solves
After we removed the automatic redirect from
/welcome
to/welcome/accounts
if wallet is connected, the Network Selector started requiring an extra click to see the list of your Safes. This PR fixes that.The Network Select will now take you straight to
/welcome/accounts
if wallet is connected.