safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

Fix: improve chain switch redirect #3769

Closed katspaugh closed 1 month ago

katspaugh commented 1 month ago

What it solves

After we removed the automatic redirect from /welcome to /welcome/accounts if wallet is connected, the Network Selector started requiring an extra click to see the list of your Safes. This PR fixes that.

The Network Select will now take you straight to /welcome/accounts if wallet is connected.

github-actions[bot] commented 1 month ago

Branch preview

βœ… Deploy successful!

Website: https://chain_redirect--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://chain_redirect--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.05 KB (🟑 +35 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

francovenica commented 1 month ago

Had to read the conversation in the review to understand what it was the purpose of the ticket.

LGTM Being in a safe of NetworkA and switching to networkB in the top right corner takes the user to the safe selection (/welcome/accounts) instead of the welcome page (/welcome).

It seems this only happens if the user is connected. I think diconnected users also can be taken to the /welcome/accounts page since the user might have safes in his watchlist, but is not a blocker

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.47% (-0.02% πŸ”»)
11307/14228
πŸ”΄ Branches
58.44% (-0.02% πŸ”»)
2704/4627
🟑 Functions
66.57% (-0.04% πŸ”»)
1820/2734
🟒 Lines
80.85% (-0.02% πŸ”»)
10197/12612
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟒 |
`...` / index.tsx
|
82.35% (-8.82% πŸ”»)
|
66.67% (-16.67% πŸ”»)
|
50% (-12.5% πŸ”»)
|
83.87% (-9.68% πŸ”»)
|

Test suite run success

1437 tests passing in 197 suites.

Report generated by πŸ§ͺjest coverage report action from 645eec6b1bebce047c54f2594e574fe75b1fbdb4