safe-global / safe-wallet-web

Safe{Wallet} – multisig EVM wallet
https://app.safe.global
GNU General Public License v3.0
344 stars 409 forks source link

fix: Add network to Rabby if unknown #3776

Closed usame-algan closed 4 months ago

usame-algan commented 4 months ago

What it solves

Part of #3745

How this PR fixes it

In Rabby, the error when trying to switch to a network that is not yet added is nested and doesn't pass our condition. It now checks for a nested code in the error that is thrown.

How to test it

  1. Remove Sepolia network from Rabby
  2. Connect to a Sepolia Safe
  3. Create / Execute a transaction or sign a message
  4. Observe there is no error and instead Rabby pops up to add Sepolia as a new network

Screenshots

Screenshot 2024-05-30 at 13 52 15

Checklist

github-actions[bot] commented 4 months ago

Branch preview

βœ… Deploy successful!

Website: https://fix_rabby_add_network--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_rabby_add_network--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 4 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

usame-algan commented 4 months ago

The second commit is still the lint issues that happen to me whenever I try to push something. Would be nice if we could get this merged to dev soon because I've added these lint fixes probably 5 times now in different PRs πŸ˜ͺ

github-actions[bot] commented 4 months ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.02 KB (🟑 +46 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.24 KB (🟑 +6 B) 979.26 KB
/home 57.41 KB (🟑 +3 B) 1007.43 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 4 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.49% (+0.01% πŸ”Ό)
11298/14213
πŸ”΄ Branches
58.48% (-0.02% πŸ”»)
2700/4617
🟑 Functions
66.7% (+0.04% πŸ”Ό)
1823/2733
🟒 Lines
80.88% (+0.01% πŸ”Ό)
10188/12597
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟑 |
`...` / sdk.ts
|
69.79% (-1.18% πŸ”»)
|
38.1% (-4.01% πŸ”»)
| 69.23% |
68.6% (-1.27% πŸ”»)
|

Test suite run success

1436 tests passing in 197 suites.

Report generated by πŸ§ͺjest coverage report action from 15a1b541d65524798af2c4b929cf289ee41dcbb0