Closed usame-algan closed 4 months ago
β Deploy successful!
Storybook: https://fix_rabby_add_network--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
The second commit is still the lint issues that happen to me whenever I try to push something. Would be nice if we could get this merged to dev soon because I've added these lint fixes probably 5 times now in different PRs πͺ
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
950.02Β KB (π‘ +46Β B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/balances |
29.24Β KB (π‘ +6Β B) |
979.26Β KB |
/home |
57.41Β KB (π‘ +3Β B) |
1007.43Β KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.49% (+0.01% πΌ) |
11298/14213 |
π΄ | Branches | 58.48% (-0.02% π») |
2700/4617 |
π‘ | Functions | 66.7% (+0.04% πΌ) |
1823/2733 |
π’ | Lines | 80.88% (+0.01% πΌ) |
10188/12597 |
1436 tests passing in 197 suites.
Report generated by π§ͺjest coverage report action from 15a1b541d65524798af2c4b929cf289ee41dcbb0
What it solves
Part of #3745
How this PR fixes it
In Rabby, the error when trying to switch to a network that is not yet added is nested and doesn't pass our condition. It now checks for a nested
code
in the error that is thrown.How to test it
Screenshots
Checklist