github-actions[bot]
commented
1 month ago Branch preview
✅ Deploy successful!
Storybook: https://fix_predict_address--walletweb.review.5afe.dev/storybook/
Closed usame-algan closed 1 month ago
github-actions[bot]
commented
1 month ago ✅ Deploy successful!
Storybook: https://fix_predict_address--walletweb.review.5afe.dev/storybook/
github-actions[bot]
commented
1 month ago Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
Report generated by eslint-plus-action
github-actions[bot]
commented
1 month ago This analysis was generated by the Next.js Bundle Analysis action. 🤖
| Page | Size (compressed) |
|---|---|
global |
950.06 KB (🟡 +31 B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/new-safe/create |
26.68 KB (🟡 +10 B) |
976.74 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
github-actions[bot]
commented
1 month ago St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 79.47% | 11295/14213 |
| 🔴 | Branches | 58.46% | 2699/4617 |
| 🟡 | Functions | 66.67% | 1822/2733 |
| 🟢 | Lines | 80.85% | 10185/12597 |
1436 tests passing in 197 suites.
Report generated by 🧪jest coverage report action from 5b390e24aad31abbdb5ec06ddc000ba7159f551e
francovenica
commented
1 month ago LGTM
Created saveral Safes and CF safes, I didn't had any issues
What it solves
Noticed this when debugging failing e2e tests the other day. This change reduces the number of RPC requests when calling
getAvailableSaltNoncefrom 3 to 1. CallingSafeFactory.createalways checks if the factory contract(s) are deployed on the current network which is not necessary when we just want to predict a safe address.How this PR fixes it
SafeFactoryevery time we want to predict the safe addressHow to test it
To see the number of RPC requests in the network panel you have to change from passing the BrowserProvider to passing a JsonRPCProvider. Not sure if DevTools offers a way to observe requests coming from a browser extension.
Checklist