github-actions[bot]
commented
1 month ago Branch preview
✅ Deploy successful!
Website: https://pk--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6
Closed katspaugh closed 1 month ago
github-actions[bot]
commented
1 month ago ✅ Deploy successful!
Website: https://pk--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6
github-actions[bot]
commented
1 month ago Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
Report generated by eslint-plus-action
github-actions[bot]
commented
1 month ago This analysis was generated by the Next.js Bundle Analysis action. 🤖
| Page | Size (compressed) |
|---|---|
global |
1003.74 KB (🟡 +52.28 KB) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
24.86 KB (🟡 +1 B) |
1 MB |
/licenses |
4.97 KB (🟢 -29 B) |
1008.71 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
github-actions[bot]
commented
1 month ago St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 79.18% (-0.26% 🔻) |
11555/14593 |
| 🔴 | Branches | 58.3% (-0.11% 🔻) |
2791/4787 |
| 🟡 | Functions | 66.18% (-0.54% 🔻) |
1851/2797 |
| 🟢 | Lines | 80.5% (-0.25% 🔻) |
10416/12939 |
1444 tests passing in 199 suites.
Report generated by 🧪jest coverage report action from a7f0855c1f81d1f2d0772239ef2b7d55080e6751
francovenica
commented
1 month ago It looks really promising! and it will going to be really useful for automation to be able to switch owners, so test on 2/x safes can be performed
My initial feedback.
github-actions[bot]
commented
1 month ago Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
Report generated by eslint-plus-action
katspaugh
commented
1 month ago @francovenica fixed both, thank you!
katspaugh
commented
1 month ago @schmanu I ended up adding a prod check as you suggested because this will allow us to use this wallet on dev even if the CGW toggle is set to prod.
What it solves
An experimental web3-onboard module to allow connecting directly with a private key as a Safe signer.
The idea is that you can have a (non-primary) signer key stored in your password manager/OS keychain and log in with it like with a password.
The private key is then stored in the session storage and it reconnects if the page is reloaded.
adc2f">