Closed jmealy closed 1 month ago
โ Deploy successful!
Storybook: https://feat_safe_apps_swaps_block--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 1 | 0 |
Ignored | 0 | N/A |
Result: :white_check_mark: success
verifies the list of dependencies for Hooks like useEffect and similar
Report generated by eslint-plus-action
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
๐ก | Statements | 79.44% (+0.03% ๐ผ) |
11513/14493 |
๐ด | Branches | 58.52% (+0.04% ๐ผ) |
2777/4745 |
๐ก | Functions | 66.63% (-0.01% ๐ป) |
1845/2769 |
๐ข | Lines | 80.78% (+0.03% ๐ผ) |
10379/12849 |
1443 tests passing in 199 suites.
Report generated by ๐งชjest coverage report action from d8f3a18a5fd0bd9badb2abcdf5410d2b4e72131a
This analysis was generated by the Next.js Bundle Analysis action. ๐ค
Page | Size (compressed) |
---|---|
global |
950.38ย KB (-15ย B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/apps |
49.67ย KB (๐ก +672ย B) |
1000.05ย KB |
/apps/custom |
41.29ย KB (๐ก +666ย B) |
991.66ย KB |
/home |
59.46ย KB (๐ก +689ย B) |
1009.84ย KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
It's ok for me now. @schmanu ?
Ok, looks good. I've checked the things asked in the description plus what manu asked to be changed: be filtered by DEX and "Optimized with batched tx"
Question:
Currently when you search, the card leaves the first place and places just among the other apps. Would it be possible to make it appear always first since is technically not an app, so it shouldn't be mixed with them.
I don't consider this a blocker, so if too outside of the scope we can create a new ticket for just that and pass this one
Currently when you search, the card leaves the first place and places just among the other apps. Would it be possible to make it appear always first since is technically not an app, so it shouldn't be mixed with them.
Actually this seems to be a bug, we have to fix this :(
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
Currently when you search, the card leaves the first place and places just among the other apps. Would it be possible to make it appear always first since is technically not an app, so it shouldn't be mixed with them.
Should be ok now
I don't understand why so many abstraction layers were added just to show a static card in the beginning of the apps list...
@jmealy The deploy has failed, can you re-trigger it to see if it at least creates the environment again to test?
I don't understand why so many abstraction layers were added just to show a static card in the beginning of the apps list...
It was mostly so the filtering would work. Hopefully it's ok now, sorry for the mess!
But wait, so now we no longer show the safe widget when we filter?
But wait, so now we no longer show the safe widget when we filter?
I was going to comment the same thing โ๏ธ
Also I just saw that, if the card is too thin (for some viewports) the button text are in 2 rows. If you reduce the padding to 21px it fits just fine with the thiniest cards
Yes, it's fine to not show it when you filter.
Ok, the filtering is out.
See if the padding of that button can be fixed.
Beyond that the ticket is fine to be merged
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
What it solves
Resolves https://www.notion.so/safe-global/Add-a-block-to-apps-page-985e220c975b42b7950929ecb02a6715?pvs=4
How this PR fixes it
How to test it
swap
, along with other swapping apps.defi
categorytry now
should bring you to the swaps featureDon't show
should remove the card from the list. It will remain hidden unless localstorage is cleared.Screenshots
Checklist