fix: switch between swap & limit loses token [SWAP-97]

[compojoom]

What it solves

When switching betwenn Swap/Limit forms, selected tokens are reset. On CoW Swap they are synced between all forms.

How this PR fixes it

We were re-rendering the widget when the user switches between swap and a limit swap and this was causing the sellToken to reset. Now, we no longer do this

How to test it

1. Navigate to swaps
2. Select a different token
3. switch to limit order

Screenshots

Checklist

• [ ] I've tested the branch on mobile 📱
• [ ] I've documented how it affects the analytics (if at all) 📊
• [ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

[notion-workspace[bot]]

Cowswap QA feedback: When switching betwenn Swap/Limit forms, selected tokens are reset

[github-actions[bot]]

Branch preview

✅ Deploy successful!

Website: https://fix_token_reset_on_tradetype_change--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_token_reset_on_tradetype_change--walletweb.review.5afe.dev/storybook/

[github-actions[bot]]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: :white_check_mark: success
  • Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[github-actions[bot]]

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
global	950.04 KB (🟡 +2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
/swap	29.17 KB (🟡 +73 B)	979.2 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

[github-actions[bot]]

Coverage report

St.:grey_question:	Category	Percentage	Covered / Total
🟡	Statements	79.47%	11295/14213
🔴	Branches	58.46%	2699/4617
🟡	Functions	66.67%	1822/2733
🟢	Lines	80.85%	10185/12597

Test suite run success

1436 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from bd7bfc2d247855905e02cf4a1961feee75178196

[francovenica]

Question. I see it here as it is in QA in the CowSwap board in notion, but is not currently in the github board, any reason no not having it there?

I've checked and the tokens are preserverd when switching from the "Swap" form to the "limits" form, so that's correct

Question since it's not in the ticket description and it might be out of the scope: The values seems to not be maintained. is this intended? I tried to see in the original cowswap app, but currently it seems to be having problems (is not connecting the wallet and it is working really slow) so I cannot check right now

[compojoom]

Question. I see it here as it is in QA in the CowSwap board in notion, but is not currently in the github board, any reason no not having it there?

Only because our workflows suck... And I have to do the same things twice

Question since it's not in the ticket description and it might be out of the scope: The values seems to not be maintained. is this intended?

I wanted to also maintain the values, but the swap widget behaves strange there. It seems to keep separate values for swap and limit, so it doesn't apply the swap value to limit and vice versa. I'll ask @anxolin about this.