safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

fix: always show tx value #3793

Closed schmanu closed 1 month ago

schmanu commented 1 month ago

What it solves

On some resolutions the value of a transaction is cut off and not visible in the transaction review screen.

How this PR fixes it

Show value of transaction separately to the to address.

How to test it

Create a tx with value > 0 via. e.g. transaction builder.

Screenshots

Screenshot 2024-06-03 at 17 02 17 Screenshot 2024-06-06 at 14 11 35 Screenshot 2024-06-06 at 14 11 22

Checklist

github-actions[bot] commented 1 month ago

Branch preview

βœ… Deploy successful!

Website: https://fix_always_show_tx_value--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_always_show_tx_value--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 951.39 KB (🟑 +1.04 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 48.92 KB (🟒 -100 B) 1000.3 KB
/apps/custom 40.54 KB (🟒 -100 B) 991.93 KB
/apps/open 50.89 KB (🟒 -37 B) 1002.28 KB
/balances/nfts 19.16 KB (🟒 -100 B) 970.55 KB
/home 58.58 KB (🟒 -100 B) 1009.97 KB
/share/safe-app 10.12 KB (🟒 -93 B) 961.51 KB
/swap 29.08 KB (🟒 -91 B) 980.46 KB
/transactions/messages 34.88 KB (🟑 +108 B) 986.26 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.49% (-0.01% πŸ”»)
11306/14223
πŸ”΄ Branches
58.43% (-0.17% πŸ”»)
2707/4633
🟑 Functions
66.78% (-0.03% πŸ”»)
1825/2733
🟒 Lines
80.85% (-0% πŸ”»)
10193/12607
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟑 |
`...` / transactions.ts
|
68.1% (-2.59% πŸ”»)
|
30.56% (-5.56% πŸ”»)
| 36.36% |
71.72% (-3.03% πŸ”»)
| | 🟒 |
`...` / index.tsx
|
95% (-0.24% πŸ”»)
|
90.63% (+2.39% πŸ”Ό)
| 50% | 100% | | 🟒 |
`...` / index.tsx
|
82.35% (-8.82% πŸ”»)
|
66.67% (-16.67% πŸ”»)
|
50% (-12.5% πŸ”»)
|
83.87% (-9.68% πŸ”»)
| | 🟑 |
`...` / hooks.ts
|
75.47% (-0.45% πŸ”»)
| 60.61% | 62.5% |
78.13% (-0.45% πŸ”»)
| | 🟒 |
`...` / useSyncSafeMessageSigner.ts
|
86.27% (-1% πŸ”»)
|
50% (-12.5% πŸ”»)
| 62.5% |
91.11% (-0.73% πŸ”»)
| | 🟒 |
`...` / index.tsx
| 100% |
87.5% (-3.41% πŸ”»)
| 100% | 100% | | 🟒 |
`...` / index.tsx
|
96.72% (-3.28% πŸ”»)
| 72.22% |
76.92% (-23.08% πŸ”»)
|
96.61% (-3.39% πŸ”»)
| | 🟒 |
`...` / useHideAssets.ts
|
92.45% (-0.88% πŸ”»)
| 71.43% |
92.31% (-1.44% πŸ”»)
|
93.62% (-0.61% πŸ”»)
| | 🟒 |
`...` / swaps.ts
|
60% (-15% πŸ”»)
| 100% | 100% | 100% | | 🟒 |
`...` / useLoadBalances.ts
|
91.11% (-2.22% πŸ”»)
| 66.67% | 100% | 95% | | πŸ”΄ |
`...` / utils.ts
|
36.84% (-0.33% πŸ”»)
| 35.48% | 21.43% |
37.37% (-0.38% πŸ”»)
| | 🟒 |
`...` / useUserNonce.ts
|
91.67% (-8.33% πŸ”»)
| 100% | 100% |
90% (-10% πŸ”»)
| | 🟒 |
`...` / index.tsx
| 100% |
53.33% (-0.72% πŸ”»)
| 100% | 100% | | 🟒 |
`...` / useSafeMessages.ts
| 93.33% |
60% (-20% πŸ”»)
| 100% | 92.86% | | 🟒 |
`...` / useDeployGasLimit.ts
|
97.37% (-0.19% πŸ”»)
|
88.89% (-2.02% πŸ”»)
| 100% | 100% | | πŸ”΄ |
`...` / SpeedUpModal.tsx
|
38.89% (-0.3% πŸ”»)
| 0% | 0% |
39.44% (-0.29% πŸ”»)
| | 🟒 |
`...` / index.tsx
|
87.5% (-0.22% πŸ”»)
|
73.33% (-2.42% πŸ”»)
| 60% |
86.54% (-0.25% πŸ”»)
| | πŸ”΄ |
`...` / RecoverAccountFlowReview.tsx
|
46.38% (-0.1% πŸ”»)
| 0% | 0% |
46.38% (-0.1% πŸ”»)
| | πŸ”΄ |
`...` / ReviewSpendingLimitTx.tsx
|
41.54% (-0.49% πŸ”»)
| 0% | 0% |
43.55% (-0.39% πŸ”»)
|

Test suite run success

1436 tests passing in 197 suites.

Report generated by πŸ§ͺjest coverage report action from 432a937871dca0bc304c2a505909b8b244a15129

katspaugh commented 1 month ago

It would be good to fix this in the tx details as well, it also gets cut off there.

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

katspaugh commented 1 month ago

Tested, looks good! βœ…

Screenshot 2024-06-11 at 15 10 52