Closed schmanu closed 1 month ago
β Deploy successful!
Storybook: https://fix_always_show_tx_value--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
951.39Β KB (π‘ +1.04Β KB) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/apps |
48.92Β KB (π’ -100Β B) |
1000.3Β KB |
/apps/custom |
40.54Β KB (π’ -100Β B) |
991.93Β KB |
/apps/open |
50.89Β KB (π’ -37Β B) |
1002.28Β KB |
/balances/nfts |
19.16Β KB (π’ -100Β B) |
970.55Β KB |
/home |
58.58Β KB (π’ -100Β B) |
1009.97Β KB |
/share/safe-app |
10.12Β KB (π’ -93Β B) |
961.51Β KB |
/swap |
29.08Β KB (π’ -91Β B) |
980.46Β KB |
/transactions/messages |
34.88Β KB (π‘ +108Β B) |
986.26Β KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.49% (-0.01% π») |
11306/14223 |
π΄ | Branches | 58.43% (-0.17% π») |
2707/4633 |
π‘ | Functions | 66.78% (-0.03% π») |
1825/2733 |
π’ | Lines | 80.85% (-0% π») |
10193/12607 |
1436 tests passing in 197 suites.
Report generated by π§ͺjest coverage report action from 432a937871dca0bc304c2a505909b8b244a15129
It would be good to fix this in the tx details as well, it also gets cut off there.
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
Tested, looks good! β
What it solves
On some resolutions the value of a transaction is cut off and not visible in the transaction review screen.
How this PR fixes it
Show value of transaction separately to the to address.
How to test it
Create a tx with value > 0 via. e.g. transaction builder.
Screenshots
Checklist