safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

Fix: same addresses showing same balance #3795

Closed katspaugh closed 1 month ago

katspaugh commented 1 month ago

What it solves

Resolves #3794

How this PR fixes it

chainId wasn't taken into account when looking up Safes in the balances list.

github-actions[bot] commented 1 month ago

Branch preview

✅ Deploy successful!

Website: https://fix_balances--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_balances--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.01 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements 79.47% 11307/14228
🔴 Branches 58.44% 2704/4627
🟡 Functions 66.57% 1820/2734
🟢 Lines 80.85% 10197/12612

Test suite run success

1437 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 9f26e2be6a12371d8690be675f6a3d44efe071ac

katspaugh commented 1 month ago

I’ve tested it with the Daniel’s safes.