Closed katspaugh closed 1 month ago
✅ Deploy successful!
Storybook: https://fix_balances--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Page | Size (compressed) |
---|---|
global |
950.01 KB (🟡 +2 B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 79.47% | 11307/14228 |
🔴 | Branches | 58.44% | 2704/4627 |
🟡 | Functions | 66.57% | 1820/2734 |
🟢 | Lines | 80.85% | 10197/12612 |
1437 tests passing in 197 suites.
Report generated by 🧪jest coverage report action from 9f26e2be6a12371d8690be675f6a3d44efe071ac
I’ve tested it with the Daniel’s safes.
What it solves
Resolves #3794
How this PR fixes it
chainId
wasn't taken into account when looking up Safes in the balances list.