safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

Feat: top 5 assets on the dashboard #3796

Closed katspaugh closed 1 month ago

katspaugh commented 1 month ago

What it solves

A helpful widget to get a quick glance at Safe's assets + promote the Swaps feature on the Dashboard.

Screenshot 2024-06-04 at 13 31 40
github-actions[bot] commented 1 month ago

Branch preview

✅ Deploy successful!

Website: https://top_assets--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://top_assets--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 950.04 KB (-32 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.4 KB (🟡 +148 B) 979.44 KB
/home 58.68 KB (🟡 +1.22 KB) 1008.72 KB
/settings/security 8.45 KB (🟢 -5 B) 958.49 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements
79.48% (+0.03% 🔼)
11309/14228
🔴 Branches
58.42% (+0.01% 🔼)
2703/4627
🟡 Functions
66.63% (+0.07% 🔼)
1821/2733
🟢 Lines
80.86% (+0.02% 🔼)
10199/12613
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |
`...` / SendButton.tsx
| 100% | 50% | 50% | 100% |

Test suite run success

1438 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 3a95838283d717389ee3d83b24cbba1cff1e1eeb

francovenica commented 1 month ago

The list doesn't take in account if tokens were hidden in the assets tab: image image

Suggestion: Adding an empty state, so if you have no tokens in the safe it doesn't show an empty native token at the top. top assets

Suggestion 2: In networks where the swap feature is not available no swap button is shown (which is correct), but makes the widget less useful. Maybe the "Send" button can be put there for those networks.

katspaugh commented 1 month ago

Done, @francovenica 👍

francovenica commented 1 month ago

Looks good! approved