Closed katspaugh closed 1 month ago
✅ Deploy successful!
Storybook: https://top_assets--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Page | Size (compressed) |
---|---|
global |
950.04 KB (-32 B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/balances |
29.4 KB (🟡 +148 B) |
979.44 KB |
/home |
58.68 KB (🟡 +1.22 KB) |
1008.72 KB |
/settings/security |
8.45 KB (🟢 -5 B) |
958.49 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 79.48% (+0.03% 🔼) |
11309/14228 |
🔴 | Branches | 58.42% (+0.01% 🔼) |
2703/4627 |
🟡 | Functions | 66.63% (+0.07% 🔼) |
1821/2733 |
🟢 | Lines | 80.86% (+0.02% 🔼) |
10199/12613 |
1438 tests passing in 197 suites.
Report generated by 🧪jest coverage report action from 3a95838283d717389ee3d83b24cbba1cff1e1eeb
The list doesn't take in account if tokens were hidden in the assets tab:
Suggestion:
Adding an empty state, so if you have no tokens in the safe it doesn't show an empty native token at the top.
Suggestion 2: In networks where the swap feature is not available no swap button is shown (which is correct), but makes the widget less useful. Maybe the "Send" button can be put there for those networks.
Done, @francovenica 👍
Looks good! approved
What it solves
A helpful widget to get a quick glance at Safe's assets + promote the Swaps feature on the Dashboard.