safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

Fix: filter out undefined address in useSafeOverviews #3801

Closed katspaugh closed 1 month ago

katspaugh commented 1 month ago

What it solves

I'm not sure what the root cause of undefined addresses is, they seem to be already filtered by Boolean before being passed to useSafeOverviews. But here's a fix that just filters out bad values before sending a request to CGW.

github-actions[bot] commented 1 month ago

Branch preview

βœ… Deploy successful!

Website: https://overviews--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://overviews--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.39 KB (🟑 +27 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.45% (+0.05% πŸ”Ό)
11496/14469
πŸ”΄ Branches
58.56% (+0.05% πŸ”Ό)
2764/4720
🟑 Functions
66.7% (+0.07% πŸ”Ό)
1849/2772
🟒 Lines
80.81% (+0.03% πŸ”Ό)
10371/12834
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟒 |
`...` / useSafeOverviews.ts
| 100% | 100% | 100% | 100% |

Test suite run success

1443 tests passing in 199 suites.

Report generated by πŸ§ͺjest coverage report action from 8acc5ebd9b026bab4b90e2cfcd55410b0c7437a2