Analytics: remove 0x from signer address

safe-global / safe-wallet-web

Safe{Wallet} – multisig EVM wallet

https://app.safe.global

GNU General Public License v3.0

344 stars 409 forks source link

Closed katspaugh closed 4 months ago

katspaugh commented 4 months ago

Like we do with Safe addresses, signer addresses must be trimmed so that GA/BigQuery doesn't try to convert them to integers.

github-actions[bot] commented 4 months ago

✅ Deploy successful!

Website: https://slice_signer--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://slice_signer--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 4 months ago

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

^{Report generated by eslint-plus-action}

github-actions[bot] commented 4 months ago

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] commented 4 months ago

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79.47% (+0.02% 🔼)	11498/14468
🔴	Branches	58.58% (+0.02% 🔼)	2765/4720
🟡	Functions	66.74% (+0.04% 🔼)	1850/2772
🟢	Lines	80.83% (+0.02% 🔼)	10373/12833

Show files with reduced coverage 🔻

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟡 |

`...` / gtm.ts

72.31% (-0.42% 🔻)

| 60% | 62.5% |

77.78% (-0.4% 🔻)

1443 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from 2eb8b6d628bf63b62bf24bb711da632eb8904af3

francovenica commented 4 months ago

LGTM: A before/after comparison