github-actions[bot]
commented
1 month ago Branch preview
✅ Deploy successful!
Storybook: https://feat_swap_notifications_link--walletweb.review.5afe.dev/storybook/
Closed compojoom closed 1 month ago
github-actions[bot]
commented
1 month ago ✅ Deploy successful!
Storybook: https://feat_swap_notifications_link--walletweb.review.5afe.dev/storybook/
github-actions[bot]
commented
1 month ago Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
Report generated by eslint-plus-action
github-actions[bot]
commented
1 month ago This analysis was generated by the Next.js Bundle Analysis action. 🤖
| Page | Size (compressed) |
|---|---|
global |
950.31 KB (-45 B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
github-actions[bot]
commented
1 month ago St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 79.43% (-0.07% 🔻) |
11304/14231 |
| 🔴 | Branches | 58.38% (-0.21% 🔻) |
2702/4628 |
| 🟡 | Functions | 66.53% (-0.28% 🔻) |
1819/2734 |
| 🟢 | Lines | 80.82% (-0.04% 🔻) |
10197/12617 |
1438 tests passing in 197 suites.
Report generated by 🧪jest coverage report action from 25fcd4f7e6174ae0a1ad5b662178b4a13717436c
notion-workspace[bot]
commented
1 month ago
What it solves
We don’t always have the txId in the order information, but when we do we add a link to the notification. It’s highly likely that order created events won’t ever have a txId as this event is created before submitting the tx to the blockchain.
I had to extract getTxLink to a separate file as having it in useTxNotifications was causing a circular dependency error in our tests.
Resolves #
How this PR fixes it
This PR cannot guarantee that the push notification displayed will have a "view transaction" link. It all depends in what order the updates to the order will come through (whether they will be triggered through the widget or through the transaction service). If the user leaves the widget page after submitting a tx, then updates will most probably come from the tx service and there will be "view transaction" link in the notification.
How to test it
Submit an order and watch the push notifications. The "order executed" one should have a link to "view transaction".
Screenshots
Checklist