safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

Fix: move the execute button on recovery transactions to the correct column [SWAP-75] #3808

Closed jmealy closed 1 month ago

jmealy commented 1 month ago

What it solves

Resolves: https://www.notion.so/safe-global/Reposition-execute-button-for-the-recovery-transaction-ba6c3968a2c44d2f93f9f9e848bda873

How this PR fixes it

Screenshots

image

Checklist

github-actions[bot] commented 1 month ago

Branch preview

✅ Deploy successful!

Website: https://align_recovery_execute_btn--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://align_recovery_execute_btn--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 month ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 month ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 50.92 KB (-5 B) 1001.27 KB
/transactions 73.92 KB (-5 B) 1 MB
/transactions/history 73.89 KB (-5 B) 1 MB
/transactions/messages 34.77 KB (🟢 -5 B) 985.12 KB
/transactions/queue 29.16 KB (🟢 -5 B) 979.51 KB
/transactions/tx 18.91 KB (🟢 -5 B) 969.26 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements 79.48% 11507/14477
🔴 Branches 58.57% 2767/4724
🟡 Functions 66.77% 1851/2772
🟢 Lines 80.83% 10379/12840

Test suite run success

1443 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from c10acba67e0e10b9d45c22228986ba90e9b8377a

notion-workspace[bot] commented 1 month ago

Reposition execute button for the recovery transaction

francovenica commented 1 month ago

Looks like the snapshot. Passed