github-actions[bot]
commented
1 month ago Branch preview
✅ Deploy successful!
Storybook: https://consistent_multisend--walletweb.review.5afe.dev/storybook/
Closed jfschwarz closed 3 weeks ago
github-actions[bot]
commented
1 month ago ✅ Deploy successful!
Storybook: https://consistent_multisend--walletweb.review.5afe.dev/storybook/
github-actions[bot]
commented
1 month ago Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
Report generated by eslint-plus-action
github-actions[bot]
commented
1 month ago This analysis was generated by the Next.js Bundle Analysis action. 🤖
| Page | Size (compressed) |
|---|---|
global |
947.48 KB (🟢 -2.89 KB) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps/open |
53.83 KB (🟡 +2.9 KB) |
1001.31 KB |
/balances |
29.41 KB (🟡 +5 B) |
976.88 KB |
/home |
58.68 KB (🟡 +5 B) |
1006.16 KB |
/swap |
32.07 KB (🟡 +2.9 KB) |
979.54 KB |
/transactions/messages |
37.67 KB (🟡 +2.9 KB) |
985.15 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
github-actions[bot]
commented
1 month ago St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 79.47% (-0.01% 🔻) |
11496/14465 |
| 🔴 | Branches | 58.56% (-0.05% 🔻) |
2765/4722 |
| 🟡 | Functions | 66.78% (+0% 🔼) |
1849/2769 |
| 🟢 | Lines | 80.83% (-0% 🔻) |
10371/12830 |
1437 tests passing in 199 suites.
Report generated by 🧪jest coverage report action from b3ec31fe4ba87da677babc86d504c90d658a286d
liliya-soroka
commented
3 weeks ago Verified
Refactoring to generally use the latest version of the MultiSendCallOnly available for the given network. This simplification enables removing some logic for determining the MultiSendCallOnly version from the codebase.
There is no dependency between the Safe version and the multisend version, meaning any Safe can use any multisend version. Assuming that the latest MultiSendCallOnly contract version is most optimized, it doesn't make sense to use legacy versions with older Safes.
A consistent multisend address also makes the configuration of the Roles Modifier more straightforward. (Users of the Roles mod need to explicitly enable all allowed multisend addresses.)
How to test
Make some multisend transactions on different versions of Safe (1.3.0, 1.1.1, 1.4.1)