search

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
312 stars 362 forks source link

Use Gateway instead of Transaction Service to fetch module ID #3815

Open iamacook opened 3 weeks ago

iamacook commented 3 weeks ago

What is the feature about

In order to get the module ID of a module-executed transaction, it is necessary to query using the transaction hash. However, the Gateway did not support this and the Transaction Service was therefore being used directly. We have since implemented a transaction_hash query on the module-transactions endpoint of the Gateway to support this.

Fetching of the module ID from the Transaction Service should now be ported to the Gateway. The ID can be retrieved from the txId.

Note: we will eventually return the module ID in the response meaning that it need not be destructure from the txId.

The list of requirements

(The SDK will need first be updated for type safety)