github-actions[bot]
commented
3 weeks ago Branch preview
✅ Deploy successful!
Storybook: https://fix_top_assets_swaps_on_hover--walletweb.review.5afe.dev/storybook/
Open compojoom opened 3 weeks ago
github-actions[bot]
commented
3 weeks ago ✅ Deploy successful!
Storybook: https://fix_top_assets_swaps_on_hover--walletweb.review.5afe.dev/storybook/
github-actions[bot]
commented
3 weeks ago Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
| Type | Occurrences | Fixable |
|---|---|---|
| Errors | 0 | 0 |
| Warnings | 0 | 0 |
| Ignored | 0 | N/A |
Report generated by eslint-plus-action
github-actions[bot]
commented
3 weeks ago This analysis was generated by the Next.js Bundle Analysis action. 🤖
| Page | Size (compressed) |
|---|---|
global |
950.62 KB (-1 B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/home |
58.79 KB (🟡 +23 B) |
1009.42 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
github-actions[bot]
commented
3 weeks ago St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 79.49% | 11533/14509 |
| 🔴 | Branches | 58.55% | 2776/4741 |
| 🟡 | Functions | 66.76% | 1854/2777 |
| 🟢 | Lines | 80.84% | 10404/12870 |
1449 tests passing in 199 suites.
Report generated by 🧪jest coverage report action from f50d69b3c1c244edab424b057d2d9fd402c26761
katspaugh
commented
3 weeks ago I would keep it w/o hover tbh.
What it solves
Display the swap button only on hover in the "top asset" block. @TanyaEfremova @kirkkonen looks a bit weird or like a bug, because we have this space on the right now without the button.
Screenshots
Checklist