safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
312 stars 362 forks source link

Fix: explicitly pass a locale to NumberFormat #3828

Closed katspaugh closed 3 weeks ago

katspaugh commented 3 weeks ago

What it solves

Firefox doesn't play nicely with undefined as a locale parameter.

github-actions[bot] commented 3 weeks ago

Branch preview

βœ… Deploy successful!

Website: https://locale--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://locale--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 3 weeks ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 3 weeks ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.42 KB (🟑 +48 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 3 weeks ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.44% (+0.01% πŸ”Ό)
11515/14495
πŸ”΄ Branches
58.52% (+0.05% πŸ”Ό)
2778/4747
🟑 Functions
66.63% (+0% πŸ”Ό)
1845/2769
🟒 Lines
80.78% (+0% πŸ”Ό)
10381/12851
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟑 |
`...` / safeContracts.ts
|
80% (+1.74% πŸ”Ό)
|
100% (+50% πŸ”Ό)
|
58.33% (-1.67% πŸ”»)
| 75% | | 🟒 |
`...` / formatNumber.ts
| 100% |
92.86% (-7.14% πŸ”»)
| 100% | 100% | | 🟒 |
`...` / recovery-state.ts
|
95.24% (+0.08% πŸ”Ό)
|
84.21% (-2.46% πŸ”»)
| 85.71% |
96.55% (+0.06% πŸ”Ό)
|

Test suite run success

1443 tests passing in 199 suites.

Report generated by πŸ§ͺjest coverage report action from f9b7b8f40be719f33efcb4e560016c64650d3f2d