search

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
312 stars 362 forks source link

fix: do not pass negative app id #3836

Closed schmanu closed 3 weeks ago

schmanu commented 3 weeks ago

What it solves

Resolves https://www.notion.so/safe-global/Signing-message-shows-a-too_small-error-8d4a815756e142e194e56fb57638b211

How this PR fixes it

How to test it

Checklist

github-actions[bot] commented 3 weeks ago

Branch preview

✅ Deploy successful!

Website: https://fix_wallet_connect_app_id--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_wallet_connect_app_id--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 3 weeks ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 3 weeks ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] commented 3 weeks ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements 79.43% 11514/14495
🔴 Branches 58.44% 2781/4759
🟡 Functions 66.74% 1846/2766
🟢 Lines 80.76% 10380/12853

Test suite run success

1436 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from c3441ebdef5ad1ac50f4a9cc741259c19275dcaa

katspaugh commented 3 weeks ago

Tested, signing with WalletConnect works ✅