safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
312 stars 362 forks source link

Speeding up bulk executions shows wrong loading indicator #3837

Open schmanu opened 3 weeks ago

schmanu commented 3 weeks ago

Bug description

For bulk executions we do not do gas estimation in our interface. Therefore we do not store the used gasLimit in the pendingTxSlice.

The SpeedUpModal shows a loading state if the gasLimit is undefined.

We need to either

Environment

Steps to reproduce

  1. Queue and sign 2 or more transactions
  2. Execute them with a low gas price
  3. Speed them up

Expected result

The speedup modal shows the new gas price and when submitting speeds up the bulk execution

Obtained result

The speedup modal remains in a loading state. Submitting the transaction works though and the tx gets sped up.

Screenshots

Screenshot 2024-06-12 at 13 53 14