safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
312 stars 362 forks source link

Fix: Chip warnings about nested tags #3840

Closed katspaugh closed 3 weeks ago

katspaugh commented 3 weeks ago

Screenshot 2024-06-13 at 11 46 55

github-actions[bot] commented 3 weeks ago

Branch preview

βœ… Deploy successful!

Website: https://chip--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://chip--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 3 weeks ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 3 weeks ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 951.46 KB (🟑 +5 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 3 weeks ago

Coverage report

[!CAUTION] Test run failed

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 79.45% 11527/14508
πŸ”΄ Branches 58.51% 2788/4765
🟑 Functions 66.74% 1848/2769
🟒 Lines 80.77% 10390/12864

Test suite run failed

Failed tests: 2/1444. Failed suites: 1/199.
``` ● PermissionsCheck β€Ί disables the submit button when the call is not allowed and shows the permission check status ReferenceError: fetch is not defined 70 | const fetchGasOracle = async (gasPriceOracle: GasPriceOracle): Promise => { 71 | const { uri, gasParameter, gweiFactor } = gasPriceOracle > 72 | const response = await fetch(uri) | ^ 73 | if (!response.ok) { 74 | throw new Error(`Error fetching gas price from oracle ${uri}`) 75 | } at fetchGasOracle (src/hooks/useGasPrice.ts:72:20) at fetchGasOracle (src/hooks/useGasPrice.ts:117:22) at getGasPrice (src/hooks/useGasPrice.ts:200:27) at callback (src/hooks/useAsync.ts:21:21) at commitHookEffectListMount (node_modules/react-dom/cjs/react-dom.development.js:23150:26) at commitPassiveMountOnFiber (node_modules/react-dom/cjs/react-dom.development.js:24931:11) at commitPassiveMountEffects_complete (node_modules/react-dom/cjs/react-dom.development.js:24891:9) at commitPassiveMountEffects_begin (node_modules/react-dom/cjs/react-dom.development.js:24878:7) at commitPassiveMountEffects (node_modules/react-dom/cjs/react-dom.development.js:24866:3) at flushPassiveEffectsImpl (node_modules/react-dom/cjs/react-dom.development.js:27039:3) at flushPassiveEffects (node_modules/react-dom/cjs/react-dom.development.js:26984:14) at node_modules/react-dom/cjs/react-dom.development.js:26769:9 at flushActQueue (node_modules/react/cjs/react.development.js:2667:24) at act (node_modules/react/cjs/react.development.js:2582:11) at node_modules/@testing-library/react/dist/act-compat.js:63:25 at renderRoot (node_modules/@testing-library/react/dist/pure.js:159:26) at render (node_modules/@testing-library/react/dist/pure.js:246:10) at customRender (src/tests/test-utils.tsx:71:16) at Object. (src/components/tx/SignOrExecuteForm/PermissionsCheck/__test__/PermissionsCheck.test.tsx:126:35) ● PermissionsCheck β€Ί disables the submit button when the call is not allowed and shows the permission check status ReferenceError: fetch is not defined 70 | const fetchGasOracle = async (gasPriceOracle: GasPriceOracle): Promise => { 71 | const { uri, gasParameter, gweiFactor } = gasPriceOracle > 72 | const response = await fetch(uri) | ^ 73 | if (!response.ok) { 74 | throw new Error(`Error fetching gas price from oracle ${uri}`) 75 | } at fetchGasOracle (src/hooks/useGasPrice.ts:72:20) at fetchGasOracle (src/hooks/useGasPrice.ts:117:22) at getGasPrice (src/hooks/useGasPrice.ts:200:27) at callback (src/hooks/useAsync.ts:21:21) at commitHookEffectListMount (node_modules/react-dom/cjs/react-dom.development.js:23150:26) at commitPassiveMountOnFiber (node_modules/react-dom/cjs/react-dom.development.js:24931:11) at commitPassiveMountEffects_complete (node_modules/react-dom/cjs/react-dom.development.js:24891:9) at commitPassiveMountEffects_begin (node_modules/react-dom/cjs/react-dom.development.js:24878:7) at commitPassiveMountEffects (node_modules/react-dom/cjs/react-dom.development.js:24866:3) at flushPassiveEffectsImpl (node_modules/react-dom/cjs/react-dom.development.js:27039:3) at flushPassiveEffects (node_modules/react-dom/cjs/react-dom.development.js:26984:14) at node_modules/react-dom/cjs/react-dom.development.js:26769:9 at flushActQueue (node_modules/react/cjs/react.development.js:2667:24) at act (node_modules/react/cjs/react.development.js:2582:11) at node_modules/@testing-library/react/dist/act-compat.js:63:25 at renderRoot (node_modules/@testing-library/react/dist/pure.js:159:26) at render (node_modules/@testing-library/react/dist/pure.js:246:10) at customRender (src/tests/test-utils.tsx:71:16) at Object. (src/components/tx/SignOrExecuteForm/PermissionsCheck/__test__/PermissionsCheck.test.tsx:144:35) ● PermissionsCheck β€Ί disables the submit button when the call is not allowed and shows the permission check status ReferenceError: fetch is not defined 70 | const fetchGasOracle = async (gasPriceOracle: GasPriceOracle): Promise => { 71 | const { uri, gasParameter, gweiFactor } = gasPriceOracle > 72 | const response = await fetch(uri) | ^ 73 | if (!response.ok) { 74 | throw new Error(`Error fetching gas price from oracle ${uri}`) 75 | } at fetchGasOracle (src/hooks/useGasPrice.ts:72:20) at fetchGasOracle (src/hooks/useGasPrice.ts:117:22) at getGasPrice (src/hooks/useGasPrice.ts:200:27) at callback (src/hooks/useAsync.ts:21:21) at commitHookEffectListMount (node_modules/react-dom/cjs/react-dom.development.js:23150:26) at commitPassiveMountOnFiber (node_modules/react-dom/cjs/react-dom.development.js:24931:11) at commitPassiveMountEffects_complete (node_modules/react-dom/cjs/react-dom.development.js:24891:9) at commitPassiveMountEffects_begin (node_modules/react-dom/cjs/react-dom.development.js:24878:7) at commitPassiveMountEffects (node_modules/react-dom/cjs/react-dom.development.js:24866:3) at flushPassiveEffectsImpl (node_modules/react-dom/cjs/react-dom.development.js:27039:3) at flushPassiveEffects (node_modules/react-dom/cjs/react-dom.development.js:26984:14) at node_modules/react-dom/cjs/react-dom.development.js:26769:9 at flushActQueue (node_modules/react/cjs/react.development.js:2667:24) at act (node_modules/react/cjs/react.development.js:2582:11) at node_modules/@testing-library/react/dist/act-compat.js:63:25 at renderRoot (node_modules/@testing-library/react/dist/pure.js:159:26) at render (node_modules/@testing-library/react/dist/pure.js:246:10) at customRender (src/tests/test-utils.tsx:71:16) at Object. (src/components/tx/SignOrExecuteForm/PermissionsCheck/__test__/PermissionsCheck.test.tsx:165:45) ● PermissionsCheck β€Ί execute the tx when the submit button is clicked ReferenceError: fetch is not defined 70 | const fetchGasOracle = async (gasPriceOracle: GasPriceOracle): Promise => { 71 | const { uri, gasParameter, gweiFactor } = gasPriceOracle > 72 | const response = await fetch(uri) | ^ 73 | if (!response.ok) { 74 | throw new Error(`Error fetching gas price from oracle ${uri}`) 75 | } at fetchGasOracle (src/hooks/useGasPrice.ts:72:20) at fetchGasOracle (src/hooks/useGasPrice.ts:117:22) at getGasPrice (src/hooks/useGasPrice.ts:200:27) at callback (src/hooks/useAsync.ts:21:21) at commitHookEffectListMount (node_modules/react-dom/cjs/react-dom.development.js:23150:26) at commitPassiveMountOnFiber (node_modules/react-dom/cjs/react-dom.development.js:24931:11) at commitPassiveMountEffects_complete (node_modules/react-dom/cjs/react-dom.development.js:24891:9) at commitPassiveMountEffects_begin (node_modules/react-dom/cjs/react-dom.development.js:24878:7) at commitPassiveMountEffects (node_modules/react-dom/cjs/react-dom.development.js:24866:3) at flushPassiveEffectsImpl (node_modules/react-dom/cjs/react-dom.development.js:27039:3) at flushPassiveEffects (node_modules/react-dom/cjs/react-dom.development.js:26984:14) at node_modules/react-dom/cjs/react-dom.development.js:26769:9 at flushActQueue (node_modules/react/cjs/react.development.js:2667:24) at act (node_modules/react/cjs/react.development.js:2582:11) at node_modules/@testing-library/react/dist/act-compat.js:63:25 at renderRoot (node_modules/@testing-library/react/dist/pure.js:159:26) at render (node_modules/@testing-library/react/dist/pure.js:246:10) at customRender (src/tests/test-utils.tsx:71:16) at Object. (src/components/tx/SignOrExecuteForm/PermissionsCheck/__test__/PermissionsCheck.test.tsx:189:34) ```

Report generated by πŸ§ͺjest coverage report action from 1f71d3309249680267ca539fa96c0712e250f4dd