Closed katspaugh closed 2 weeks ago
✅ Deploy successful!
Website: https://span--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6
Storybook: https://span--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
@francovenica could you test this in Chrome on Windows? It seems to affect only Windows.
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Page | Size (compressed) |
---|---|
global |
951.46 KB (🟡 +1 B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 79.46% (+0.02% 🔼) |
11529/14509 |
🔴 | Branches | 58.44% (+0.02% 🔼) |
2788/4771 |
🟡 | Functions | 66.75% (+0.04% 🔼) |
1849/2770 |
🟢 | Lines | 80.78% (+0.02% 🔼) |
10392/12865 |
1444 tests passing in 199 suites.
Report generated by 🧪jest coverage report action from f7518960358826cfc216fce36a9c075628b5ee2e
I tried it in Chrome Windows, I can still see it somewhat often. Is not consistent, but it can happen by just maxing the amount of tokens. You might have to try a few times
Apparently it’s not the span.
What it solves
Resolves https://github.com/5afe/safe-support/issues/461
How this PR fixes it
I haven't been able to reproduce the ▯▯▯▯▯▯▯▯ bug but my best guess is that this empty span is the culprit.