safe-global / safe-wallet-web

Safe{Wallet} โ€“ smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
311 stars 360 forks source link

Fix: remove mobile signer promo #3852

Closed katspaugh closed 2 weeks ago

katspaugh commented 2 weeks ago

What it solves

Resolves #3824

How this PR fixes it

Removes the block from the code.

github-actions[bot] commented 2 weeks ago

Branch preview

โœ… Deploy successful!

Website: https://rm_mobile_promo--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://rm_mobile_promo--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 2 weeks ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 2 weeks ago

๐Ÿ“ฆ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. ๐Ÿค–

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/new-safe/create 26.58ย KB (๐ŸŸข -142ย B) 1.01ย MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 2 weeks ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
๐ŸŸก Statements
79.17% (+0.02% ๐Ÿ”ผ)
11555/14595
๐Ÿ”ด Branches
58.33% (+0.02% ๐Ÿ”ผ)
2791/4785
๐ŸŸก Functions
66.15% (+0.04% ๐Ÿ”ผ)
1851/2798
๐ŸŸข Lines
80.49% (+0.02% ๐Ÿ”ผ)
10416/12940

Test suite run success

1444 tests passing in 199 suites.

Report generated by ๐Ÿงชjest coverage report action from 63897d3153d2fd6635ba314cd385e27624868e77