Closed katspaugh closed 1 week ago
β³ Deploying a preview site...
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
1003.75Β KB (-2Β B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.16% (+0.01% πΌ) |
11559/14602 |
π΄ | Branches | 58.32% (+0.02% πΌ) |
2792/4787 |
π‘ | Functions | 66.13% (+0.01% πΌ) |
1851/2799 |
π’ | Lines | 80.48% (+0.01% πΌ) |
10419/12946 |
1444 tests passing in 199 suites.
Report generated by π§ͺjest coverage report action from 8897eb370b01fcc93ed25f79a8d9166bb0122286
Verified. The regression run is also passed. one failed case related to the tooltip for remove owner can be ignored ( not related to the fix)
What it solves
Tx nonce is updated in real-time when creating a new transaction. At first it takes the Safe nonce, then a recommended nonce is fetched and the safeTx object is updated with that.
This triggers two risk scanning requests where the only difference is the nonce.
How this PR fixes it
Since the risk API doesn't seem to care about nonces, I made it always send 0, as well as memoizing the payload as JSON.
How to test it
On prod (so without this fix):
risk
/messages
requestsOn this branch:
/messages
request