Closed katspaugh closed 1 week ago
β Deploy successful!
Storybook: https://approve_swap--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
1003.82Β KB (π‘ +2Β B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 79.19% (+0.01% πΌ) |
11598/14646 |
π΄ | Branches | 58.44% (-0.03% π») |
2812/4812 |
π‘ | Functions | 66.11% | 1857/2809 |
π’ | Lines | 80.52% (+0.01% πΌ) |
10456/12986 |
1446 tests passing in 199 suites.
Report generated by π§ͺjest coverage report action from ef88a476aae7a12a048bcbdd8fa96cf6d45a3ff9
Reload makes a new view Π°ΡΠΊ for the approver worse than the current approval position on prod
https://github.com/safe-global/safe-wallet-web/assets/338622/0fc90ae8-b706-4b00-8a03-16daf00c9ee4
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
Verified
What it solves
A few UI adjustments for the Approval Editor in swap transactions.
edit
orsave
.Before
After
Links
Internal discussion: https://5afe.slack.com/archives/C06GBBW39QU/p1718885834196179