safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
311 stars 360 forks source link

Fix: delay chainChanged event in test wallet #3859

Closed katspaugh closed 1 week ago

katspaugh commented 1 week ago

What it solves

Onboard cannot subscribe to the chainChanged event if it's emitted synchronously right after connecting. Giving it a small delay allows onboard to subscribe to this event and fetch an ENS name and account balance of the connected address.

github-actions[bot] commented 1 week ago

Branch preview

βœ… Deploy successful!

Website: https://test_wallet--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://test_wallet--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

πŸŽ‰ Global Bundle Size Decreased

Page Size (compressed)
global 1003.8Β KB (-19Β B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.15% (+0.02% πŸ”Ό)
11592/14645
πŸ”΄ Branches
58.41% (+0.01% πŸ”Ό)
2810/4811
🟑 Functions
66.07% (-0.02% πŸ”»)
1856/2809
🟒 Lines
80.48% (+0.02% πŸ”Ό)
10450/12984

Test suite run success

1446 tests passing in 199 suites.

Report generated by πŸ§ͺjest coverage report action from 3b67c9a51559299c170b657b4a765cd25b61dbf8