Feat: create deep link page for messages

jmealy commented 1 week ago

What it solves

Resolves #2020

How this PR fixes it

Create a deep link page for displaying a single message.
Link to this single message page from the sign message modal and from the message details in the history.

How to test it

Create a message for a 2/n safe (eg. log in to opensea via walletconnect)
Sign the message using the first signer of the safe.
Once the message has one signature, there should be a link to share the message with the other signers [1]
Go to the message history. There should also be a share link in the message details, similar to transactions. [2]
The link should lead to a page displaying that message by itself.

Screenshots

[1] [2]

Checklist

[ ] I've tested the branch on mobile 📱
[ ] I've documented how it affects the analytics (if at all) 📊
[ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://single_msg_page--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://single_msg_page--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1000.21 KB` (🟡 +31 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page	Size (compressed)	First Load
`/transactions/msg`	`29.42 KB`	1.01 MB

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/transactions/messages`	`39.02 KB` (🟡 +1.09 KB)	1.01 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79% (+0.25% 🔼)	11492/14546
🔴	Branches	58.21% (+0.17% 🔼)	2782/4779
🟡	Functions	65.93% (+0.19% 🔼)	1838/2788
🟢	Lines	80.35% (+0.21% 🔼)	10359/12893

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

| 100% | 100% | 50% | 100% | | 🟢 |

`...` / useOrigin.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / index.tsx

| 100% | 75% | 100% | 100% | | 🟢 |

`...` / ExpandableMsgItem.tsx

| 100% | 0% | 100% | 100% | | 🟢 |

`...` / index.tsx

| 100% | 60% | 100% | 100% | | 🟢 |

`...` / index.tsx

| 94.12% | 53.33% | 50% | 93.75% | | 🟡 |

`...` / index.tsx

| 76.92% | 45.45% | 33.33% | 76% | | 🟢 |

`...` / index.tsx

| 85% | 0% | 100% | 88.89% |

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / transaction-guards.ts

|

79.87% (+1.12% 🔼)

|

47.5% (-5.69% 🔻)

|

77.08% (-1.35% 🔻)

|

80.2% (-0.54% 🔻)

| | 🟢 |

`...` / useSafeMessage.ts

|

90.48% (-4.26% 🔻)

|

66.67% (-33.33% 🔻)

| 75% |

94.74% (+0.29% 🔼)

| | 🟢 |

`...` / utils.ts

|

80.52% (-0.49% 🔻)

| 66.67% | 80% |

82.35% (-0.26% 🔻)

| | 🟡 |

`...` / useTransactionType.ts

|

67.57% (-0.85% 🔻)

|

41.03% (+1.03% 🔼)

| 100% |

68.57% (-0.87% 🔻)

| | 🟡 |

`...` / index.tsx

|

65.38% (-2.36% 🔻)

| 0% | 0% |

70.83% (-1.58% 🔻)

| | 🔴 |

`...` / index.tsx

|

35.56% (-1.81% 🔻)

| 0% | 0% |

37.65% (-1.89% 🔻)

|

Test suite run success

1415 tests passing in 196 suites.

Report generated by 🧪jest coverage report action from 771a054f76120b3c3093b6452288718002f92cdf

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica commented 3 days ago

LGTM

The link is fine, it copies the the url properly. Looks good in dark mode and mobile viewports

github-actions[bot] commented 1 day ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

safe-global / safe-wallet-web