Refactor: lazy-load governance widget

katspaugh commented 1 week ago

What it solves

Part of #3323

The governance widget makes a few requests to CGW from below the fold. This PR defers the rendering of this widget until the user scrolls to it.

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://lazy_gov--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://lazy_gov--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1003.94 KB` (🟡 +11 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/home`	`56.42 KB` (🟢 -166 B)	1.04 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79.16% (-0.03% 🔻)	11602/14656
🔴	Branches	58.44% (-0.03% 🔻)	2818/4822
🟡	Functions	66.07% (-0.04% 🔻)	1856/2809
🟢	Lines	80.49% (-0.03% 🔻)	10460/12995

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

|

82.35% (-8.82% 🔻)

|

66.67% (-16.67% 🔻)

|

50% (-12.5% 🔻)

|

83.87% (-9.68% 🔻)

| | 🔴 |

`...` / useOnceVisible.ts

|

12% (-1.04% 🔻)

| 0% | 0% |

13.64% (-0.65% 🔻)

|

Test suite run success

1446 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from e61650435874633feb35b64993f3d6e43a3bc294

francovenica commented 1 week ago

LGTM. The widget doesn't load anymore as soon as you enter in the dashboard (since the widget is visible for a second), instead it loads as you scroll down.

safe-global / safe-wallet-web