Fix: wrong number formatting in SingleTxDecoded

katspaugh commented 1 week ago

What it solves

The wrong number formatting function was called in SingleTxDecoded. It resulted in double formatting which failed in locales where the decimal separator is a comma (e.g. pt-PT).

How to test it

Set your browser language to Portuguese (Portugal)
Go to tx history and expand a multisend transaction containing fractional amount transfers
In prod: they would be displayed as NaN
On this branch: they are displayed correctly

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://fix_format--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_format--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`999.51 KB` (-10 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79.18% (+0.15% 🔼)	11604/14655
🔴	Branches	58.46% (+0.16% 🔼)	2819/4822
🟡	Functions	66.11% (+0.07% 🔼)	1857/2809
🟢	Lines	80.51% (+0.11% 🔼)	10462/12994

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / useSafeCreation.ts

| 90% | 84.38% | 55.56% | 90.67% | | 🟡 |

`...` / index.tsx

| 78.95% | 54.55% | 50% | 77.78% | | 🟡 |

`...` / StatusMessage.tsx

| 65.22% | 31.25% | 100% | 63.64% | | 🟡 |

`...` / index.tsx

| 62.16% | 33.33% | 42.86% | 61.11% | | 🟢 |

`...` / useSafeCreationEffects.ts

| 86.67% | 90% | 80% | 85.71% | | 🔴 |

`...` / address-book.ts

| 38.46% | 0% | 0% | 33.33% | | 🟢 |

`...` / usePendingSafe.ts

| 93.75% | 80% | 100% | 93.33% | | 🟢 |

`...` / StatusStepper.tsx

| 66.67% | 0% | 0% | 80% | | 🟡 |

`...` / StatusStep.tsx

| 63.64% | 0% | 0% | 70% |

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🔴 |

`...` / undeployedSafesSlice.ts

|

44.12% (-2.94% 🔻)

| 33.33% | 62.5% | 50% | | 🟢 |

`...` / txMonitor.ts

|

92.47% (+0.47% 🔼)

|

92% (-2.44% 🔻)

|

96% (+0.55% 🔼)

|

93.18% (+0.22% 🔼)

| | 🟢 |

`...` / useGasPrice.ts

|

95% (-1.25% 🔻)

|

80.95% (-2.38% 🔻)

| 100% |

94.81% (-1.3% 🔻)

| | 🟢 |

`...` / index.tsx

|

96.77% (-0.1% 🔻)

| 92.59% | 100% | 100% |

Test suite run success

1446 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from fca2b914adf0cd69dfefaba0451c1c8692666fd3

francovenica commented 1 week ago

LGTM. Leaving here a before/after snapshot for the sake of documentation:

safe-global / safe-wallet-web