iteration on Roles integration

jfschwarz commented 1 week ago

Taking into account the feedback points from design & QA, this PR improves the integration of role-based access control into the execution flow previously delivered with #3768.

Integrate into the main "execute or sign" card

Previously we've integrated the execution through a role as new card appearing above the default "execute or sign" card. As suggested by the wallet design team, we've now improved the user experience by enabling the execution through a role directly from the default form.

Call is allowed for the role:

Call is not allowed:

Logic: default execution as owner vs execution as role member

This PR only affects creating new transactions. The confirm flow for previously proposed transaction remains unchanged.
If the connected wallet is not an owner but a role member, we present the form for execution as role member.
If the connected wallet is both, an owner and a role member, we present the form for execution as role member only if the threshold is >1 (no direct execution as owner possible).

Handle edge cases with batch transactions

So far we didn't correctly handle cases where the Role mod expects a different multi-send address than the one used per default in Safe Wallet. This PR fixes it through a lookup of the multi-send address configured on the Roles mod and routing the batch transaction accordingly.

More user-friendly error messages for failing permission checks

Review the complete list of potential messages here.

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://role_multisend_fix--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://role_multisend_fix--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`1000.1 KB` (-1 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 1 week ago

Coverage report

[!CAUTION] Test run failed

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	78.79% (-0.01% 🔻)	11440/14520
🔴	Branches	58.24% (+0.12% 🔼)	2789/4789
🟡	Functions	65.8% (+0.02% 🔼)	1837/2792
🟢	Lines	80.16% (-0.02% 🔻)	10306/12857

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

| 87.1% | 70.59% | 100% | 87.78% | | 🟡 |

`...` / hooks.ts

| 79.38% | 60.81% | 81.08% | 78.99% |

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

|

82.35% (-8.82% 🔻)

|

66.67% (-16.67% 🔻)

|

50% (-12.5% 🔻)

|

83.87% (-9.68% 🔻)

|

Test suite run failed

Failed tests: 1/1417. Failed suites: 1/196.

``` ● ReviewSignMessageOnChain › can handle messages with EIP712Domain type in the JSON-RPC payload thrown: "Exceeded timeout of 5000 ms for a test. Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout." 23 | 24 | describe('ReviewSignMessageOnChain', () => { > 25 | test('can handle messages with EIP712Domain type in the JSON-RPC payload', async () => { | ^ 26 | jest.spyOn(web3, 'getWeb3ReadOnly').mockImplementation(() => new JsonRpcProvider()) 27 | jest.spyOn(useSafeInfo, 'default').mockImplementation( 28 | () => at test (src/components/tx-flow/flows/SignMessageOnChain/ReviewSignMessageOnChain.test.tsx:25:3) at Object.describe (src/components/tx-flow/flows/SignMessageOnChain/ReviewSignMessageOnChain.test.tsx:24:1) ```

Report generated by 🧪jest coverage report action from 6655d398c6c4e323c59da640aa3b96b5ff9efd61

github-actions[bot] commented 3 days ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

safe-global / safe-wallet-web