safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
310 stars 358 forks source link

Fix separators in different sections of interface #3870

Open TanyaEfremova opened 1 week ago

TanyaEfremova commented 1 week ago

Bug description

  1. Modals: Decrease separator thickness to 1px (as we don't have 2px dividers anywhere else). This should be applied to all modals, not only modals shown below.

    Screenshot 2024-06-25 at 15 41 05 Screenshot 2024-06-25 at 15 44 59 Screenshot 2024-06-25 at 15 44 32
  2. Swaps: Remove a line above the order details in expanded transactions in history and queue (we don't have them in other transactions)

    Screenshot 2024-06-25 at 15 44 04

Environment

Steps to reproduce

  1. Go to e.g. Address book and click Import or Export, see modal
  2. Make a swap and expand a transaction in history and/or queu

Expected result

Described above.

Obtained result

Screenshots

MHarisAshfaq commented 6 days ago

Hi @TanyaEfremova, I hope you're doing well. I just wanted to ask a question

TanyaEfremova commented 23 hours ago

Hey @MHarisAshfaq , here is an overview of all the modals requiring adjusted separators.

In total, it is 5 modals.

Screenshot 2024-07-01 at 17 54 46 Screenshot 2024-07-01 at 17 54 54 Screenshot 2024-07-01 at 17 55 01 Screenshot 2024-07-01 at 17 53 51 Screenshot 2024-07-01 at 17 54 40
MHarisAshfaq commented 23 hours ago

@TanyaEfremova Please assign this task to me. I want to do it.

MHarisAshfaq commented 2 hours ago

@TanyaEfremova I have raised the PR for this issue. Please assign the relevant person for the review. Thank you for the guidance.