Remove border from message txs in History

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)

https://app.safe.global

GNU General Public License v3.0

311 stars 360 forks source link

Remove border from message txs in History #3871

Closed TanyaEfremova closed 1 week ago

TanyaEfremova commented 1 week ago

Bug description

Remove the border from the transactions in Messages tab, so that they are the same as other transaction cells in History.

Environment

Browser: Chrome
Wallet: MetaMask
Chain: Ethereum mainnet

Steps to reproduce

Go to a Safe account with messages
Open Messages tab in Transactions

Expected result

No border shown, like on the screenshot below.

Obtained result

Screenshots

MHarisAshfaq commented 1 week ago

@TanyaEfremova I want to do this task. Please assign it to me.

katspaugh commented 1 week ago

Theek hai, chalo bhai sahab! Agar khuch savaal hai, to mujse puchiye :)

MHarisAshfaq commented 1 week ago

@katspaugh I encountered difficulties during the initial setup, specifically configuring the required environment variables. Despite following the instructions in the README file, I am struggling to correctly configure all the necessary variables.

Could you please provide a list of the required environment variables needed to run the UI? This information would greatly help me proceed with my contributions.

katspaugh commented 1 week ago

None of the env vars are required to run the app locally.

You can open this Safe to see the message history.

Here's the same link on localhost: http://localhost:3000/transactions/messages?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

MHarisAshfaq commented 1 week ago

@katspaugh I have raised the PR. Please have a look and let me know If anything further is required. Thanks for your guidance.