safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
311 stars 360 forks source link

fix: update recommendedNonce when history tag changes #3872

Closed schmanu closed 1 week ago

schmanu commented 1 week ago

What it solves

Updates useRecommendedNonce for 1/1 Safes that execute a transaction directly.

How this PR fixes it

Fetched the recommended nonce when the safe's txHistoryTag changes. Reason being that 1/1 Safe transactions that get executed immediately never hit the queue and thus do not update the txQueuedTag.

Adds a unit test for useRecommendedNonce

How to test it

Checklist

github-actions[bot] commented 1 week ago

Branch preview

βœ… Deploy successful!

Website: https://fix_recommended_nonce--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_recommended_nonce--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

This PR introduced no changes to the JavaScript bundle! πŸ™Œ

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
78.82% (+0.08% πŸ”Ό)
11346/14394
πŸ”΄ Branches
58.27% (+0.08% πŸ”Ό)
2744/4709
🟑 Functions
65.79% (+0.07% πŸ”Ό)
1823/2771
🟒 Lines
80.16% (+0.05% πŸ”Ό)
10223/12753

Test suite run success

1413 tests passing in 195 suites.

Report generated by πŸ§ͺjest coverage report action from 360dec563c17d115bc592d7613476b0a4a936401

liliya-soroka commented 1 week ago

Verified