safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
311 stars 360 forks source link

Tests: Fix tests #3873

Closed mike10ca closed 1 week ago

mike10ca commented 1 week ago

What it solves

How this PR fixes it

How to test it

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://fix_test_errors--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_test_errors--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1003.42 KB (🟡 +3.44 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Nineteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 51.54 KB (🟢 -1.82 KB) 1.03 MB
/balances 29.43 KB (🟡 +1 B) 1.01 MB
/home 60.04 KB (🟡 +1.41 KB) 1.04 MB
/new-safe/create 26.72 KB (🟢 -7.1 KB) 1.01 MB
/new-safe/load 16.39 KB (🟢 -62 B) 1019.81 KB
/privacy 15.76 KB (🟢 -140 B) 1019.18 KB
/settings/appearance 8.44 KB (🟡 +432 B) 1011.86 KB
/settings/data 7.54 KB (🟡 +1 B) 1010.96 KB
/settings/modules 9.62 KB (🟢 -1 B) 1013.04 KB
/settings/notifications 28.07 KB (🟡 +463 B) 1.01 MB
/settings/safe-apps 25.96 KB (🟡 +415 B) 1.01 MB
/settings/security 8.45 KB (🟡 +393 B) 1011.87 KB
/settings/setup 35.96 KB (🟡 +1 B) 1.02 MB
/swap 29.91 KB (🟢 -160 B) 1.01 MB
/transactions 73.93 KB (🟡 +186 B) 1.05 MB
/transactions/history 73.89 KB (🟡 +184 B) 1.05 MB
/transactions/messages 34.87 KB (🟢 -2.96 KB) 1.01 MB
/transactions/queue 29.16 KB (🟢 -1.78 KB) 1.01 MB
/transactions/tx 18.91 KB (🟢 -1.8 KB) 1022.33 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements 79.15% 11551/14594
🔴 Branches 58.31% 2790/4785
🟡 Functions 66.12% 1850/2798
🟢 Lines 80.47% 10412/12939

Test suite run success

1444 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from 6bd9dc1da6ef35963216be57b8171fbc1c0c3fb8