feat: add a warning if changing the fallback handler [SW-53]

compojoom commented 2 days ago

What it solves

If the user is submitting a TWAP order for the first time he would most probably need to change his safe's fallback handler. Whenever we detect this we now show a warning:

Resolves #

How this PR fixes it

How to test it

Try to create a TWAP order on a safe that has the standard fallback handler. The first tx should display the warning in the screenshot.

Screenshots

Checklist

[ ] I've tested the branch on mobile 📱
[ ] I've documented how it affects the analytics (if at all) 📊
[ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions[bot] commented 2 days ago

Branch preview

✅ Deploy successful!

Website: https://feat_cow_fallback--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://feat_cow_fallback--walletweb.review.5afe.dev/storybook/

notion-workspace[bot] commented 2 days ago

Missing fallback handler warning

github-actions[bot] commented 2 days ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 2 days ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1000.65 KB` (🟡 +93 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 2 days ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	78.9% (+0.02% 🔼)	11589/14688
🔴	Branches	58.08% (+0.09% 🔼)	2815/4847
🟡	Functions	65.86% (+0.06% 🔼)	1850/2809
🟢	Lines	80.32% (+0.02% 🔼)	10453/13015

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

| 75% | 100% | 0% | 100% |

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

| 96% |

92.86% (-0.48% 🔻)

| 100% | 100% | | 🟢 |

`...` / useGasPrice.ts

|

95% (-1.25% 🔻)

|

80.95% (-2.38% 🔻)

| 100% |

94.81% (-1.3% 🔻)

| | 🔴 |

`...` / SwapTx.tsx

|

45.45% (-4.55% 🔻)

| 0% | 0% |

50% (-7.14% 🔻)

| | 🟢 |

`...` / index.tsx

|

88.89% (+0.56% 🔼)

|

71.05% (-1.17% 🔻)

| 60% |

88.14% (+0.64% 🔼)

|

Test suite run success

1426 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 04e695a535937588c48c3dac8aa5e26056c36496

safe-global / safe-wallet-web