safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
311 stars 360 forks source link

fix: Close notification center when a notification is opened #3890

Open usame-algan opened 2 days ago

usame-algan commented 2 days ago

What it solves

Resolves #3810

How this PR fixes it

How to test it

  1. Create a transaction
  2. Open the transaction detail page
  3. Open the notification center
  4. Press "View transaction"
  5. Observe that the UI is still clickable

Checklist

github-actions[bot] commented 2 days ago

Branch preview

βœ… Deploy successful!

Website: https://fix_notification_center--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_notification_center--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 2 days ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 2 days ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1000.19 KB (🟑 +9 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 2 days ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
78.78% (+0.02% πŸ”Ό)
11396/14466
πŸ”΄ Branches
58.06% (+0.02% πŸ”Ό)
2759/4752
🟑 Functions
65.77% (+0.04% πŸ”Ό)
1829/2781
🟒 Lines
80.16% (+0.02% πŸ”Ό)
10270/12812

Test suite run success

1413 tests passing in 195 suites.

Report generated by πŸ§ͺjest coverage report action from 2dc612c8ead290a36e2429a514cd2a1b4812bc70