fix: Hide add to address book button if address already in address book

usame-algan commented 3 months ago

What it solves

Resolves #3826

How this PR fixes it

Hides the Add to address book icon in the address input field if an address already exists in the address book

How to test it

Open a Safe
Create a transaction
Select a recipient from the address book
Observe there is no icon button next to the address
Type in an address thats not in the address book yet
Either press the icon next to the address or the link below the input field
Observe that the address is pre-populated in the form

Screenshots

Checklist

[ ] I've tested the branch on mobile 📱
[ ] I've documented how it affects the analytics (if at all) 📊
[ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions[bot] commented 3 months ago

Branch preview

✅ Deploy successful!

Website: https://add_to_address_book--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://add_to_address_book--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 3 months ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 3 months ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1000.22 KB` (🟡 +6 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/new-safe/create`	`33.76 KB` (🟡 +4 B)	1.01 MB
`/new-safe/load`	`16.39 KB` (🟡 +4 B)	1016.61 KB
`/transactions`	`73.43 KB` (🟡 +5 B)	1.05 MB
`/transactions/history`	`73.39 KB` (🟡 +5 B)	1.05 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 3 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	78.93% (-0.02% 🔻)	11529/14607
🔴	Branches	58.07% (+0.01% 🔼)	2796/4815
🟡	Functions	65.87% (-0.04% 🔻)	1841/2795
🟢	Lines	80.31% (-0.02% 🔻)	10395/12943

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / index.tsx

|

82.35% (-8.82% 🔻)

|

66.67% (-16.67% 🔻)

|

50% (-12.5% 🔻)

|

83.87% (-9.68% 🔻)

|

Test suite run success

1415 tests passing in 196 suites.

Report generated by 🧪jest coverage report action from 1bb1c4972872051c8aa4d3a3552e7090a1d472cc

francovenica commented 2 months ago

Looks good. The icon shows if the address is not in the address book The address is filled in the form when adding it to the AB

safe-global / safe-wallet-web