safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

Fix buy order [SW-50] #3895

Closed compojoom closed 1 week ago

compojoom commented 1 week ago

What it solves

We were displaying wrong amount in the queue and history when the user was making a buy order.

grafik

How to test it

  1. Create a buy order
  2. in queue and history you should see "{sell token icon} to {buy token icon} {amount buy token}" grafik

Screenshots

Checklist

github-actions[bot] commented 1 week ago

Branch preview

βœ… Deploy successful!

Website: https://fix_buy_order--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_buy_order--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1000.21 KB (🟑 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

notion-workspace[bot] commented 1 week ago

Fix Buy order amount for Buy swap/twap orders

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
78.77% (-0.16% πŸ”»)
11392/14463
πŸ”΄ Branches
57.99% (-0.04% πŸ”»)
2758/4756
🟑 Functions
65.73% (-0.14% πŸ”»)
1828/2781
🟒 Lines
80.15% (-0.17% πŸ”»)
10266/12809
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟒 |
`...` / safeTheme.ts
|
90.7% (-2.33% πŸ”»)
| 50% |
90% (-3.33% πŸ”»)
|
92.68% (-2.44% πŸ”»)
| | 🟒 |
`...` / SignMessage.tsx
|
91.18% (-0.25% πŸ”»)
|
77.27% (-4.36% πŸ”»)
| 69.23% |
91.92% (-0.24% πŸ”»)
| | 🟒 |
`...` / index.tsx
| 97.06% |
78.95% (-5.26% πŸ”»)
| 100% | 96.67% | | πŸ”΄ |
`...` / index.tsx
|
52.38% (-16.37% πŸ”»)
| 0% | 0% |
55% (-18.33% πŸ”»)
|

Test suite run success

1413 tests passing in 195 suites.

Report generated by πŸ§ͺjest coverage report action from 9bda1c52290925ecd9c878d9592f05019bda6424