safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

fix: Hide native swaps card from custom apps list #3896

Closed usame-algan closed 1 week ago

usame-algan commented 1 week ago

What it solves

Resolves #3887

How this PR fixes it

How to test it

  1. Open the custom apps list
  2. Observe no native swaps card

Screenshots

Screenshot 2024-07-03 at 11 03 13

Checklist

github-actions[bot] commented 1 week ago

Branch preview

βœ… Deploy successful!

Website: https://hide_native_swaps_card--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://hide_native_swaps_card--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.13 KB (🟑 +4 B) 1.03 MB
/apps/custom 41.75 KB (🟑 +4 B) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 78.93% 11529/14607
πŸ”΄ Branches
58.04% (+0.01% πŸ”Ό)
2793/4812
🟑 Functions 65.87% 1841/2795
🟒 Lines 80.31% 10395/12943

Test suite run success

1415 tests passing in 196 suites.

Report generated by πŸ§ͺjest coverage report action from 67c7dad414139a99f49d30f46c43b6828de559b0