Open usame-algan opened 1 week ago
β Deploy successful!
Storybook: https://tx_data_scroll--walletweb.review.5afe.dev/storybook/
Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.
Type | Occurrences | Fixable |
---|---|---|
Errors | 0 | 0 |
Warnings | 0 | 0 |
Ignored | 0 | N/A |
Report generated by eslint-plus-action
This analysis was generated by the Next.js Bundle Analysis action. π€
Page | Size (compressed) |
---|---|
global |
1000.78Β KB (π‘ +3Β B) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 78.86% | 11598/14707 |
π΄ | Branches | 58.01% | 2817/4856 |
π‘ | Functions | 65.74% | 1850/2814 |
π’ | Lines | 80.27% | 10460/13031 |
1426 tests passing in 197 suites.
Report generated by π§ͺjest coverage report action from 553233ef40188f2f85a03904056395e193ea7bae
Well, is hard to say if it is fixed since Curve, for some reason, do not allow me to connect my safe to the app in this PR (even after connecting with "Saefe" curve just says that I need to be in "the Safe Environment") , so I cannot sign a tx to see the modal
I decided to check it by creating a tx in prod and queue it to see it in this PR with Prod CGW. Being in queue is not the same as the tx modal, but I know the same overflow issue is there. so I was able to check that it was fixed there:
What it solves
Resolves #2682
How this PR fixes it
overflow-x: auto
property toDataRow
componentHow to test it
TxDataRow
/DataRow
component is also used for Swaps, TxSummary, MsgDetails, RecoveryDetails. Make sure these places still work as expectedScreenshots
https://github.com/safe-global/safe-wallet-web/assets/5880855/d19435a6-8df8-4f34-b07f-e136b8f1ef0d
Checklist