safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

fix: Make transaction details scrollable during creation #3899

Open usame-algan opened 1 week ago

usame-algan commented 1 week ago

What it solves

Resolves #2682

How this PR fixes it

How to test it

  1. Create a swap on Curve
  2. Observe the tx details in the review screen can be fully viewed by scrolling
  3. The TxDataRow / DataRow component is also used for Swaps, TxSummary, MsgDetails, RecoveryDetails. Make sure these places still work as expected

Screenshots

https://github.com/safe-global/safe-wallet-web/assets/5880855/d19435a6-8df8-4f34-b07f-e136b8f1ef0d

Checklist

github-actions[bot] commented 1 week ago

Branch preview

βœ… Deploy successful!

Website: https://tx_data_scroll--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://tx_data_scroll--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1000.78 KB (🟑 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 78.86% 11598/14707
πŸ”΄ Branches 58.01% 2817/4856
🟑 Functions 65.74% 1850/2814
🟒 Lines 80.27% 10460/13031

Test suite run success

1426 tests passing in 197 suites.

Report generated by πŸ§ͺjest coverage report action from 553233ef40188f2f85a03904056395e193ea7bae

francovenica commented 23 hours ago

Well, is hard to say if it is fixed since Curve, for some reason, do not allow me to connect my safe to the app in this PR (even after connecting with "Saefe" curve just says that I need to be in "the Safe Environment") , so I cannot sign a tx to see the modal

I decided to check it by creating a tx in prod and queue it to see it in this PR with Prod CGW. Being in queue is not the same as the tx modal, but I know the same overflow issue is there. so I was able to check that it was fixed there: image image