Release 1.39.0 - Githubissues

compojoom commented 1 week ago

Main Highlights

TWAP order support is now in place! Swap fees are displayed in the decoded information, and we’ve added warnings for poisoning transactions. Enjoy the updates! 🚀 🌔

Swaps

feat: TWAP order decoding in tx history/queue [SW-1] (#3861)
feat: TWAP decoding on confirmation screen [SW-2] (#3865)
feat: Display swap info on sent/receive events [SW-3] (#3877)
feat: add a warning if changing the fallback handler (#3889)
feat: Do not show swaps feature to users from blocked counties [SW-48] (#3892)
feat: swaps fees [SW-34] (#3880)

Address poisoning

Feat: Show warning for address poisoning transactions (#3851)

Other improvements

feat: visually group transactions executed in bulk in the transaction history (#3772)
feat: Add method to Sign in with Ethereum [SW-28] (#3853)
feat: create deep link page for messages (#3863)
feat: Improve safe creation status screen (#3778)
feat: private key signer (#3784)
refactor: lazy-load governance widget (#3864)

Fixes

fix: Hide native swaps card from custom apps list (#3896)
fix: swapTxInfo for buy orders shows wrong value (#3895)
fix: wrong number formatting in SingleTxDecoded (#3868)
fix: removed border from messages txs (#3874)
fix: update recommendedNonce when history tag changes (#3872)
fix: Display cow fallback handler message [SW-33] (#3882)
fix: update meta description (#3866)
fix: adjust approval editor with swaps (#3855)
fix: full token amount in tx details (#3848)
fix: redirect routes w/o ?safe (#3846)
fix: add loading indicator for safe list (#3860)
fix: delay chainChanged event in test wallet (#3859)
fix: remove mobile signer promo (#3852)
fix: signTypedData for the test wallet (#3850)
fix: Close transaction modals as soon as the transaction is submitted (#3676)

Tests

tests: add testid for pk input
tests: E2e wallet (#3878)
tests: Increase waiters in swap tests (#3886)
tests: Add swap tests (#3884)
tests: Add swap tests (#3845)
tests: Fix happy path tests (#3849)
tests: Fix regression tests (#3862)

Other

chrore: update privacy policy (#3857)

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://release--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://release--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1000.8 KB` (🟡 +27 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/balances`	`29.47 KB` (🟢 -17 B)	1.01 MB
`/home`	`58.7 KB` (🟢 -7 B)	1.03 MB
`/settings/cookies`	`7.64 KB` (🟢 -2 B)	1008.44 KB
`/terms`	`11.59 KB` (🟡 +1.57 KB)	1012.4 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	79.01% (-0.47% 🔻)	11613/14698
🔴	Branches	58.6% (+0.08% 🔼)	2847/4858
🟡	Functions	65.97% (-0.82% 🔻)	1855/2812
🟢	Lines	80.4% (-0.39% 🔻)	10471/13024

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / cookiesAndTermsSlice.ts

| 63.64% | 100% | 33.33% | 85.71% | | 🟢 |

`...` / types.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / index.ts

| 16.67% | 0% | 0% | 18.18% | | 🟢 |

`...` / pk-popup-store.ts

| 80% | 50% | 0% | 88.89% | | 🟡 |

`...` / session.ts

| 70% | 50% | 50% | 71.43% | | 🟢 |

`...` / index.tsx

| 100% | 100% | 50% | 100% | | 🟢 |

`...` / useOrigin.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / useIsSwapFeatureEnabled.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / index.tsx

| 40% | 0% | 0% | 38.46% | | 🔴 |

`...` / SwapTx.tsx

| 50% | 0% | 0% | 57.14% | | 🟢 |

`...` / index.tsx

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / index.tsx

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / useUndeployedSafe.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / constants.ts

| 50% | 100% | 100% | 100% | | 🟢 |

`...` / fee.ts

| 100% | 92.86% | 100% | 100% | | 🟢 |

`...` / stablecoins.ts

| 100% | 100% | 100% | 100% | | 🟡 |

`...` / PartDuration.tsx

| 50% | 100% | 0% | 60% | | 🟡 |

`...` / PartSellAmount.tsx

| 62.5% | 0% | 0% | 71.43% | | 🟡 |

`...` / PartBuyAmount.tsx

| 62.5% | 0% | 0% | 71.43% | | 🟡 |

`...` / OrderFeeConfirmationView.tsx

| 54.55% | 0% | 0% | 60% | | 🟢 |

`...` / index.tsx

| 75% | 100% | 0% | 100% | | 🟢 |

`...` / index.tsx

| 75% | 100% | 0% | 100% | | 🟢 |

`...` / interactWith.tsx

| 57.14% | 0% | 0% | 80% | | 🟢 |

`...` / EmptyRow.tsx

| 66.67% | 100% | 0% | 100% | | 🔴 |

`...` / SurplusFee.tsx

| 41.67% | 0% | 0% | 45.45% | | 🔴 |

`...` / index.tsx

| 50% | 0% | 0% | 54.17% | | 🟢 |

`...` / index.tsx

| 100% | 75% | 100% | 100% | | 🟢 |

`...` / ExpandableMsgItem.tsx

| 100% | 0% | 100% | 100% | | 🟢 |

`...` / index.tsx

| 100% | 60% | 100% | 100% | | 🟢 |

`...` / index.tsx

| 94.12% | 53.33% | 50% | 93.75% | | 🟡 |

`...` / index.tsx

| 76.92% | 45.45% | 33.33% | 76% | | 🟢 |

`...` / index.tsx

| 85% | 0% | 100% | 88.89% |

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟢 |

`...` / transaction-guards.ts

|

78.75% (-1.67% 🔻)

|

53.19% (+3.19% 🔼)

|

78.43% (+0.17% 🔼)

|

80.73% (+0.32% 🔼)

| | 🟢 |

`...` / safeCoreSDK.ts

|

89.09% (-3.5% 🔻)

| 84.62% |

85.71% (-14.29% 🔻)

|

91.67% (-1.95% 🔻)

| | 🟡 |

`...` / extractTxInfo.ts

|

76.74% (-1.83% 🔻)

|

45.45% (-2.05% 🔻)

| 100% |

76.19% (-1.86% 🔻)

| | 🟡 |

`...` / notificationsSlice.ts

|

76.67% (-3.33% 🔻)

| 16.67% |

46.15% (-7.69% 🔻)

|

72.73% (-4.55% 🔻)

| | 🔴 |

`...` / undeployedSafesSlice.ts

|

41.18% (-2.94% 🔻)

| 33.33% |

50% (-12.5% 🔻)

|

45.83% (-4.17% 🔻)

| | 🟢 |

`...` / swapParamsSlice.ts

|

66.67% (+3.03% 🔼)

| 100% |

0% (-33.33% 🔻)

|

87.5% (+1.79% 🔼)

| | 🟡 |

`...` / utils.ts

|

75.26% (-5.26% 🔻)

|

63.16% (-3.51% 🔻)

|

76.19% (-3.81% 🔻)

|

77.38% (-4.97% 🔻)

| | 🔴 |

`...` / useOnboard.ts

|

44.17% (-0.46% 🔻)

| 11.11% | 15% |

47.17% (-0.49% 🔻)

| | 🟡 |

`...` / gtm.ts

|

70.77% (-1.54% 🔻)

| 60% |

50% (-12.5% 🔻)

| 77.78% | | 🟡 |

`...` / wallets.ts

|

65% (-2.57% 🔻)

|

25% (-3.57% 🔻)

| 77.78% |

68.75% (-1.25% 🔻)

| | 🟢 |

`...` / txMonitor.ts

|

92% (-0.47% 🔻)

|

94.44% (+2.44% 🔼)

|

95.45% (-0.55% 🔻)

|

92.96% (-0.22% 🔻)

| | 🟡 |

`...` / sdk.ts

|

66.34% (-1.7% 🔻)

| 38.1% |

57.14% (-4.4% 🔻)

|

65.56% (-1.11% 🔻)

| | 🟢 |

`...` / index.tsx

|

82.35% (-8.82% 🔻)

|

66.67% (-16.67% 🔻)

|

50% (-12.5% 🔻)

|

83.87% (-9.68% 🔻)

| | 🟢 |

`...` / useSafeMessage.ts

|

90.48% (-4.26% 🔻)

|

66.67% (-33.33% 🔻)

| 75% |

94.74% (+0.29% 🔼)

| | 🟢 |

`...` / index.tsx

|

91.3% (-0.36% 🔻)

| 75% | 50% |

95.24% (-0.22% 🔻)

| | 🟢 |

`...` / tx-history-filter.ts

| 100% |

86.49% (-2.08% 🔻)

| 100% | 100% | | 🔴 |

`...` / utils.ts

|

36.52% (-0.65% 🔻)

|

34.38% (-1.11% 🔻)

| 21.43% |

37% (-0.76% 🔻)

| | 🟢 |

`...` / index.tsx

| 100% |

96% (-4% 🔻)

| 100% | 100% | | 🟢 |

`...` / index.tsx

| 100% |

50% (-3.33% 🔻)

| 100% | 100% | | 🟢 |

`...` / index.tsx

|

96.77% (-0.1% 🔻)

| 92.59% | 100% | 100% | | 🟡 |

`...` / index.tsx

|

66.67% (-9.86% 🔻)

|

41.86% (-11.26% 🔻)

|

61.54% (-11.19% 🔻)

|

66.67% (-10.51% 🔻)

| | 🔴 |

`...` / index.ts

|

47.83% (-21.85% 🔻)

|

18.18% (-40.91% 🔻)

|

10% (-37.06% 🔻)

|

48.33% (-20.53% 🔻)

| | 🟡 |

`...` / useTransactionType.ts

|

68.42% (-1.02% 🔻)

|

40% (-2.11% 🔻)

| 100% |

69.44% (-1.14% 🔻)

| | 🟢 |

`...` / index.tsx

|

88.89% (+1.17% 🔼)

|

71.05% (-4.7% 🔻)

| 60% |

88.14% (+1.34% 🔼)

| | 🟡 |

`...` / DataTable.tsx

| 50% |

0% (-100% 🔻)

| 0% | 66.67% | | 🟡 |

`...` / index.tsx

|

73.08% (-21.04% 🔻)

|

25% (+25% 🔼)

|

66.67% (-33.33% 🔻)

|

72.73% (-20.13% 🔻)

| | 🟡 |

`...` / index.tsx

|

74.55% (-1.38% 🔻)

|

16.13% (-0.54% 🔻)

| 66.67% |

75.47% (-1.45% 🔻)

| | 🔴 |

`...` / index.tsx

|

38.04% (-14.46% 🔻)

| 0% | 0% |

40.23% (-18.1% 🔻)

| | 🔴 |

`...` / useOnceVisible.ts

|

12% (-1.04% 🔻)

| 0% | 0% |

13.64% (-0.65% 🔻)

| | 🟢 |

`...` / useGetSafeInfo.ts

|

84.21% (-4.68% 🔻)

|

20% (-30% 🔻)

|

40% (-10% 🔻)

|

88.24% (-5.51% 🔻)

| | 🔴 |

`...` / recovery-sender.ts

|

12% (-1.21% 🔻)

| 0% | 0% |

12% (-1.21% 🔻)

| | 🟢 |

`...` / useAdjustUrl.ts

|

93.75% (-6.25% 🔻)

|

80% (-20% 🔻)

| 100% |

93.33% (-6.67% 🔻)

|

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 51c068e605ea2de87a0771978657ee15cfd38183

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

safe-global / safe-wallet-web

Release 1.39.0 #3900

Main Highlights

Swaps

Address poisoning

Other improvements

Fixes

Tests

Other

Branch preview

ESLint Summary View Full Report

📦 Next.js Bundle Analysis for safe-wallet-web

⚠️ Global Bundle Size Increased

Four Pages Changed Size

Coverage report

Test suite run success

ESLint Summary View Full Report

ESLint Summary View Full Report